Commits on Aug 2, 2023

1. disable smooth scrolling when opening/closing Dialogs …

   For iOS workaround related purposes we have to capture the scroll
   position and offset the margin top with that amount and then
   `scrollTo(0,0,)` to prevent all kinds of funny UI jumps.
   
   However, if you have `scroll-behavior: smooth` enabled on your `html`,
   then offseting the margin-top and later `scrollTo(0,0)` would be
   handled in a smooth way, which means that the actual position would be
   off.
   
   To solve this, we disable smooth scrolling entirely in order to make the
   position of the Dialog correct. This shouldn't be a problem in practice
   since the page itself isn't suppose to scroll anyway.
   
   Once the Dialog closes we reset it such that everything else keeps
   working as expected in a (smooth) way.

   

   RobinMalfait committed Aug 2, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for beb0c4e
   • Browse repository at this point

   Copy the full SHA

   beb0c4e View commit details

   Browse the repository at this point in the history

2. add microTask to disposables

   

   RobinMalfait committed Aug 2, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for c94d654
   • Browse repository at this point

   Copy the full SHA

   c94d654 View commit details

   Browse the repository at this point in the history

3. ensure the fix works in React's double rendering dev mode

   

   RobinMalfait committed Aug 2, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for 555c0fc
   • Browse repository at this point

   Copy the full SHA

   555c0fc View commit details

   Browse the repository at this point in the history

4. update changelog

   

   RobinMalfait committed Aug 2, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for 3735db2
   • Browse repository at this point

   Copy the full SHA

   3735db2 View commit details

   Browse the repository at this point in the history