Improve internal demo mode #3143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This still disabled `inert` and focus stealing code. But it does allow outside click.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Before this, once you start interacting with the `Combobox`, the options weren't properly scrolled into view.
RobinMalfait
force-pushed
the
improve-demo-mode
branch
from
76bb216
to
0b931f2
Compare
RobinMalfait
commented
Apr 26, 2024
Comment on lines
-130
to
-136
|
|
||
| /* We can turn off demo mode once we re-open the `Popover` */ | ||
| if (nextState.popoverState === PopoverStates.Open) { | ||
| nextState.__demoMode = false | ||
| } | ||
|
|
||
| return nextState |
There was a problem hiding this comment.
We can always turn off demo mode 👍
Comment on lines
-1756
to
-1757
| if (!data.virtual) return | ||
| if (!data.__demoMode) return |
There was a problem hiding this comment.
These conditions were incorrect. We don't want to scroll into view when virtual mode is used or when demo mode is used.
thecrypticace
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the internal demo modes for the following components:
DialogComboboxMenuPopoverThis PR also adds a demo mode for the
Listboxcomponent.