New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve internal demo mode #3143
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
23c2d8d
improve demo mode for the `Dialog` component
RobinMalfait 99f454c
improve demo mode for the `Combobox` component
RobinMalfait 40a0107
improve demo mode for the `Menu` component
RobinMalfait 0dbfb0d
improve demo mode for the `Popover` component
RobinMalfait 0b931f2
add demo mode to the `Listbox` component
RobinMalfait File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -81,7 +81,6 @@ enum PopoverStates { | |
} | ||
|
||
interface StateDefinition { | ||
__demoMode: boolean | ||
popoverState: PopoverStates | ||
|
||
buttons: MutableRefObject<Symbol[]> | ||
|
@@ -93,6 +92,8 @@ interface StateDefinition { | |
|
||
beforePanelSentinel: MutableRefObject<HTMLButtonElement | null> | ||
afterPanelSentinel: MutableRefObject<HTMLButtonElement | null> | ||
|
||
__demoMode: boolean | ||
} | ||
|
||
enum ActionTypes { | ||
|
@@ -120,24 +121,18 @@ let reducers: { | |
) => StateDefinition | ||
} = { | ||
[ActionTypes.TogglePopover]: (state) => { | ||
let nextState = { | ||
return { | ||
...state, | ||
popoverState: match(state.popoverState, { | ||
[PopoverStates.Open]: PopoverStates.Closed, | ||
[PopoverStates.Closed]: PopoverStates.Open, | ||
}), | ||
__demoMode: false, | ||
} | ||
|
||
/* We can turn off demo mode once we re-open the `Popover` */ | ||
if (nextState.popoverState === PopoverStates.Open) { | ||
nextState.__demoMode = false | ||
} | ||
|
||
return nextState | ||
Comment on lines
-130
to
-136
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We can always turn off demo mode 👍 |
||
}, | ||
[ActionTypes.ClosePopover](state) { | ||
if (state.popoverState === PopoverStates.Closed) return state | ||
return { ...state, popoverState: PopoverStates.Closed } | ||
return { ...state, popoverState: PopoverStates.Closed, __demoMode: false } | ||
}, | ||
[ActionTypes.SetButton](state, action) { | ||
if (state.button === action.button) return state | ||
|
@@ -863,7 +858,7 @@ function PanelFn<TTag extends ElementType = typeof DEFAULT_PANEL_TAG>( | |
useOnDisappear(state.button, () => dispatch({ type: ActionTypes.ClosePopover }), visible) | ||
|
||
// Enable scroll locking when the popover is visible, and `modal` is enabled | ||
useScrollLock(ownerDocument, modal && visible) | ||
useScrollLock(ownerDocument, state.__demoMode ? false : modal && visible) | ||
|
||
let handleKeyDown = useEvent((event: ReactKeyboardEvent<HTMLButtonElement>) => { | ||
switch (event.key) { | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These conditions were incorrect. We don't want to scroll into view when virtual mode is used or when demo mode is used.