Fix premature end of tests (and running sibling tests) when test includes subtests #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you re-title your PR to be more descriptive about what it does? Which issue it fixes is incidental :-) |
nhamer
changed the title
ljharb
force-pushed
the
issue222
branch
2 times, most recently
from
3ae4a87
to
45a5066
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ljharb
force-pushed
the
issue222
branch
2 times, most recently
from
c083bce
to
fbe4b95
Compare
ljharb
approved these changes
Jan 30, 2019
ljharb
added a commit
that referenced
this pull request
Feb 9, 2019
[New] Implements TAP TODO directive (#254) [New] add alias 'notDeepEquals' to 'notDeepEqual' function (#411) [Fix] fix premature end of tests (and running sibling tests) when test includes subtests (#403, #222) [Fix] only use one test runner for results, even if multiple streams are created (#404, #361, #105) [Fix] windows: Show failure location even if driver letter is lowercase (#329) [Docs] link to mixed tape (#445) [Docs] Add electron-tap (#240) [Docs] Add tape-promise into 'other' (#210) [Docs] Mention [`flip-tape`](https://github.com/pguth/flip-tape/blob/master/README.md) in the section "other". (#359) [Docs] Add an alternative ES6 tape runner (#328)
orangejulius
added a commit
to pelias/whosonfirst
that referenced
this pull request
Feb 12, 2019
As of tape-testing/tape#403, tape requires calling `end()` at the end of top level tests if there are only nested tests. We use this pattern extensively Fixes #420
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #222
For reference, a version which doesn't fix the ordering of asserts vs subtests is at https://github.com/nhamer/tape/tree/issue222_early_subtest