Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused import #745

Merged
merged 1 commit into from Apr 29, 2021
Merged

Remove unused import #745

merged 1 commit into from Apr 29, 2021

Conversation

jsumners
Copy link
Contributor

This is to solve issue #743. The issue actually only happens when a project has an .npmrc with legacy-bundling=true set. This causes bin/jack.js to not find the dependency because it hasn't been flattened out to the top-level of node_modules. As far as I know, it's effectively impossible to write a test for this case. However, the dependency is completely unused in the bin/jack.js code, so the fix is simple: remove the import.

@jsumners
Copy link
Contributor Author

@isaacs or @coreyfarrell what do you think?

@jsumners @isaacs
Remove unused import
f5b805d 
PR-URL: tapjs#745
Credit: @jsumners
Close: tapjs#745
Reviewed-by: @isaacs
@isaacs
Copy link
Member

isaacs commented Apr 29, 2021

Thanks!

@isaacs isaacs closed this in f5b805d Apr 29, 2021
@isaacs isaacs merged commit f5b805d into tapjs:main Apr 29, 2021
@jsumners jsumners deleted the issue-743 branch April 29, 2021 17:18
@jsumners jsumners mentioned this pull request May 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jsumners @isaacs