Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Renovate): ⬆️ Update dependency vite to v4.3.9 [SECURITY] #349

Merged
merged 2 commits into from Jun 22, 2023

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jun 6, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
vite (source) 4.3.4 -> 4.3.9 age adoption passing confidence

GitHub Vulnerability Alerts

CVE-2023-34092

Summary

Vite Server Options (server.fs.deny) can be bypassed using double forward-slash (//) allows any unauthenticated user to read file from the Vite root-path of the application including the default fs.deny settings (['.env', '.env.*', '*.{crt,pem}'])

Impact

Only users explicitly exposing the Vite dev server to the network (using --host or server.host config option) are affected, and only files in the immediate Vite project root folder could be exposed.

Patches

Fixed in vite@4.3.9, vite@4.2.3, vite@4.1.5, vite@4.0.5
And in the latest minors of the previous two majors: vite@3.2.7, vite@2.9.16

Details

Vite serve the application with under the root-path of the project while running on the dev mode. By default, vite using server options fs.deny to protected the sensitive information of the file. But, with simply double forward-slash, we can bypass this fs restriction.

PoC

  1. Create a new latest project of vite using any package manager. (here I'm using react and vue templates for tested and pnpm)
  2. Serve the application on dev mode using pnpm run dev.
  3. Directly access the file from url using double forward-slash (//) (e.g: //.env, //.env.local)
  4. Server Options fs.deny restrict successfully bypassed.

Proof Images:
proof-1
proof-2


Release Notes

vitejs/vite

v4.3.9

Compare Source

v4.3.8

Compare Source

v4.3.7

Compare Source

v4.3.6

Compare Source

v4.3.5

Compare Source


Configuration

📅 Schedule: Branch creation - "" in timezone Asia/Taipei, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added 📦 package:vitest-config Related to the package - Vitest configuration 🧩 dependencies Related to the dependencies labels Jun 6, 2023
@changeset-bot
Copy link

changeset-bot bot commented Jun 6, 2023

🦋 Changeset detected

Latest commit: 50ad772

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@terminal-nerds/vitest-config Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codeclimate
Copy link

codeclimate bot commented Jun 6, 2023

Code Climate has analyzed commit 578bf1b and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented Jun 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2023

Size Change: 0 B

Total Size: 15.7 kB

ℹ️ View Unchanged
Filename Size
./packages/browserslist/dist/browsers.cjs 175 B
./packages/browserslist/dist/browsers.js 168 B
./packages/browserslist/dist/node.cjs 229 B
./packages/browserslist/dist/node.js 219 B
./packages/constants/dist/main.cjs 275 B
./packages/constants/dist/main.js 241 B
./packages/eslint/dist/index.cjs 4.26 kB
./packages/lint-staged/dist/checks.js 186 B
./packages/lint-staged/dist/chunk-C53NRLTQ.js 269 B
./packages/lint-staged/dist/chunk-E5QKDC6D.js 262 B
./packages/lint-staged/dist/chunk-I6ACKE4G.js 274 B
./packages/lint-staged/dist/chunk-L7HP726B.js 399 B
./packages/lint-staged/dist/chunk-PTN2BGKU.js 224 B
./packages/lint-staged/dist/chunk-R5YPEEHD.js 236 B
./packages/lint-staged/dist/chunk-XLFBJMFG.js 339 B
./packages/lint-staged/dist/chunk-ZETN7CNJ.js 226 B
./packages/lint-staged/dist/groups/code-format.js 131 B
./packages/lint-staged/dist/groups/eslint.js 106 B
./packages/lint-staged/dist/groups/markdown.js 111 B
./packages/lint-staged/dist/groups/package-json.js 134 B
./packages/lint-staged/dist/groups/stylesheets.js 117 B
./packages/lint-staged/dist/groups/tests.js 105 B
./packages/lint-staged/dist/groups/typescript.js 114 B
./packages/lint-staged/dist/main.js 435 B
./packages/markdownlint/dist/index.json 304 B
./packages/prettier/dist/index.cjs 1.17 kB
./packages/stylelint/dist/index.cjs 3.15 kB
./packages/syncpack/dist/index.cjs 413 B
./packages/tsup/dist/main.js 551 B
./packages/vitest/dist/base.js 128 B
./packages/vitest/dist/chunk-T256VEOW.js 258 B
./packages/vitest/dist/chunk-XZHYECMR.js 207 B
./packages/vitest/dist/main.js 158 B
./packages/vitest/dist/with-coverage.js 148 B

compressed-size-action

@ghost
Copy link

ghost commented Jun 6, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@socket-security
Copy link

New and updated dependency changes detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives1 Size Publisher
vite ⬆️ 4.3.4...4.3.9 None +0/-0 3.25 MB vitebot

Footnotes

  1. https://docs.socket.dev

@xeho91 xeho91 merged commit 1f6970a into main Jun 22, 2023
11 of 13 checks passed
@xeho91 xeho91 deleted the renovate/npm-vite-vulnerability branch June 22, 2023 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧩 dependencies Related to the dependencies 📦 package:vitest-config Related to the package - Vitest configuration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant