Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

image: set forcenew=false on min_disk_gb, min_ram_mb, protected #1299

Conversation

rossengeorgiev
Copy link
Contributor

@rossengeorgiev rossengeorgiev commented Oct 13, 2021

On images allow setting these properties in-place: min_disk_gb, min_ram_mb, protected

Closes #1287

⚠ I'm not sure whether this is all I need to do to fix this. There maybe code and tests that need to be modified

@theopenlab-ci
Copy link

theopenlab-ci bot commented Oct 13, 2021

@rossengeorgiev rossengeorgiev marked this pull request as ready for review November 27, 2021 16:06
@rossengeorgiev rossengeorgiev force-pushed the update-image-props-without-forced-replace branch from 384f202 to 88f6653 Compare December 8, 2021 15:30
@theopenlab-ci
Copy link

theopenlab-ci bot commented Dec 8, 2021

Copy link
Member

@ozerovandrei ozerovandrei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @rossengeorgiev

@ozerovandrei ozerovandrei merged commit 9a4601e into terraform-provider-openstack:main Dec 9, 2021
@rossengeorgiev rossengeorgiev deleted the update-image-props-without-forced-replace branch December 25, 2022 09:55
@rossengeorgiev rossengeorgiev restored the update-image-props-without-forced-replace branch December 25, 2022 09:55
@rossengeorgiev rossengeorgiev deleted the update-image-props-without-forced-replace branch December 25, 2022 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

openstack_images_image_v2 forces replacement when changing protected property
2 participants