Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade TypeScript to v5.0 #858

Merged
merged 3 commits into from Jan 14, 2024

Conversation

lesha1201
Copy link
Contributor

@lesha1201 lesha1201 commented Dec 14, 2023

Checks

Changes

Context

Based on #856. See 4c28716...0f6fe96 for changes.

@lesha1201
Copy link
Contributor Author

CI for Node v12 failed because TypeScript dropped support for it in v5.1 (https://www.typescriptlang.org/docs/handbook/release-notes/typescript-5-1.html#es2020-and-nodejs-1417-as-minimum-runtime-requirements). I will change TypeScript version to v5 then.

@Belco90
Copy link
Member

Belco90 commented Jan 12, 2024

Hey @lesha1201! Can you update this PR to remove the ESLint changes, and get the new CI config? Thanks.

@lesha1201
Copy link
Contributor Author

@Belco90 I will try to do this tomorrow if I will have time. The next week I'm quite busy and probably will be able to do this only on the next weekends if I can't tomorrow.

@Belco90
Copy link
Member

Belco90 commented Jan 13, 2024

@lesha1201 No rush! Thanks for your help.

Copy link

codecov bot commented Jan 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@9126dc7). Click here to learn what that means.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #858   +/-   ##
=======================================
  Coverage        ?   96.23%           
=======================================
  Files           ?       44           
  Lines           ?     2419           
  Branches        ?     1000           
=======================================
  Hits            ?     2328           
  Misses          ?       91           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lesha1201
Copy link
Contributor Author

@Belco90 Done

Copy link
Member

@Belco90 Belco90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Belco90 Belco90 changed the title chore: upgrade TypeScript chore: upgrade TypeScript to v5.0 Jan 14, 2024
@Belco90 Belco90 added this pull request to the merge queue Jan 14, 2024
Merged via the queue into testing-library:main with commit 93a6ab9 Jan 14, 2024
31 checks passed
Copy link

🎉 This PR is included in version 6.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants