Get supported roles for toBeChecked via aria-query #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Helper to join arrays of strings into natural language enumerations separating the last two items with a coordinating conjunction like "and" or "or".
Instead of hard coding a list of roles, use information provided by the `aria-query` package to determine whether an element with a given role supports the `aria-checked` attribute. Dynamically generate an error message listing all supported roles. Make error message expectations more fuzzy to prevent test failures if the list of supported roles should ever change.
Codecov Report
@@ Coverage Diff @@
## master #267 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 23 23
Lines 315 320 +5
Branches 71 71
=========================================
+ Hits 315 320 +5
Continue to review full report at Codecov.
|
gnapse
approved these changes
Jun 25, 2020
|
@all-contributors add @tf for code, test, idea |
|
I've put up a pull request to add @tf! 🎉 |
|
🎉 This PR is included in version 5.11.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of hard coding a list of roles, use information provided by the
aria-querypackage to determine whether an element with a given rolesupports the
aria-checkedattribute.Dynamically generate an error message listing all supported roles. Make
error message expectations more fuzzy to prevent test failures if the list
of supported roles should ever change.
Fixes #266