fix(tab): make tab respect radio groups (fix #207) #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Codecov Report
@@ Coverage Diff @@
## master #330 +/- ##
==========================================
+ Coverage 99.34% 99.37% +0.02%
==========================================
Files 2 2
Lines 305 319 +14
Branches 79 84 +5
==========================================
+ Hits 303 317 +14
Misses 2 2
Continue to review full report at Codecov.
|
nickmccurdy
changed the title
benmonro
reviewed
Jun 9, 2020
benmonro
approved these changes
Jun 9, 2020
nickmccurdy
force-pushed
the
pr/make-tab-respect-radio-groups
branch
from
feb77bb
to
93da220
Compare
Closed
nickmccurdy
changed the title
|
Sorry I force pushed this to clean up the commit message, not realizing you reviewed. If you're okay with this for now we can merge, unless you want the behavior documented somewhere first. |
benmonro
approved these changes
Jun 9, 2020
|
🎉 This PR is included in version 11.3.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: make tab respect radio groups
Why: fixes bugs / inaccurate simulation with
tab()naively focusing all radio buttonsHow: ignore radio buttons that aren't checked or at the ends within their named groups
Checklist:
The algorithm I used to prune irrelevant radio buttons is a bit ugly and hacky because of all the edge cases, so I'd appreciate any ideas to improve it. We also might need to carefully document this change as it could cause tests to fail if they're relying on the incorrect focusing behavior (though changing incorrect functionality to fix a bug is technically not a breaking change in semver).