Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #26881 - use dynamic attrs for Factory Bot 5.x compat #274

Merged
merged 1 commit into from Jun 11, 2019
Merged

Fixes #26881 - use dynamic attrs for Factory Bot 5.x compat #274

merged 1 commit into from Jun 11, 2019

Conversation

mmoll
Copy link
Contributor

@mmoll mmoll commented May 25, 2019

No description provided.

@mmoll
Copy link
Contributor Author

mmoll commented May 25, 2019

test failures unrelated, AFAICT

@tbrisker
Copy link
Member

[test foreman_ansible]

@tbrisker
Copy link
Member

tests are now failing due to peerigon/parse-domain#72

@tbrisker
Copy link
Member

[test foreman_ansible]

@tbrisker
Copy link
Member

rex tests are now failing here:

/usr/local/rvm/gems/ruby-2.5.1@foreman_ansible-pull-request-1/gems/factory_bot-5.0.2/lib/factory_bot/definition_proxy.rb:97:in `method_missing': undefined method 'template' in 'job_template' factory (NoMethodError)
	from /usr/local/rvm/gems/ruby-2.5.1@foreman_ansible-pull-request-1/gems/foreman_remote_execution-1.8.0/test/factories/foreman_remote_execution_factories.rb:5:in `block (2 levels) in <top (required)>'
	from /usr/local/rvm/gems/ruby-2.5.1@foreman_ansible-pull-request-1/gems/factory_bot-5.0.2/lib/factory_bot/syntax/default.rb:18:in `instance_eval'
	from /usr/local/rvm/gems/ruby-2.5.1@foreman_ansible-pull-request-1/gems/factory_bot-5.0.2/lib/factory_bot/syntax/default.rb:18:in `factory'
	from /usr/local/rvm/gems/ruby-2.5.1@foreman_ansible-pull-request-1/gems/foreman_remote_execution-1.8.0/test/factories/foreman_remote_execution_factories.rb:2:in `block in <top (required)>'
	from /usr/local/rvm/gems/ruby-2.5.1@foreman_ansible-pull-request-1/gems/factory_bot-5.0.2/lib/factory_bot/syntax/default.rb:49:in `instance_eval'
	from /usr/local/rvm/gems/ruby-2.5.1@foreman_ansible-pull-request-1/gems/factory_bot-5.0.2/lib/factory_bot/syntax/default.rb:49:in `run'
	from /usr/local/rvm/gems/ruby-2.5.1@foreman_ansible-pull-request-1/gems/factory_bot-5.0.2/lib/factory_bot/syntax/default.rb:7:in `define'
	from /usr/local/rvm/gems/ruby-2.5.1@foreman_ansible-pull-request-1/gems/foreman_remote_execution-1.8.0/test/factories/foreman_remote_execution_factories.rb:1:in `<top (required)>'
	from /usr/local/rvm/gems/ruby-2.5.1@foreman_ansible-pull-request-1/gems/activesupport-5.2.1/lib/active_support/dependencies.rb:281:in `load'
	from /usr/local/rvm/gems/ruby-2.5.1@foreman_ansible-pull-request-1/gems/activesupport-5.2.1/lib/active_support/dependencies.rb:281:in `block in load'
	from /usr/local/rvm/gems/ruby-2.5.1@foreman_ansible-pull-request-1/gems/activesupport-5.2.1/lib/active_support/dependencies.rb:253:in `load_dependency'
	from /usr/local/rvm/gems/ruby-2.5.1@foreman_ansible-pull-request-1/gems/activesupport-5.2.1/lib/active_support/dependencies.rb:281:in `load'
	from /usr/local/rvm/gems/ruby-2.5.1@foreman_ansible-pull-request-1/gems/factory_bot-5.0.2/lib/factory_bot/find_definitions.rb:20:in `block (2 levels) in find_definitions'
	from /usr/local/rvm/gems/ruby-2.5.1@foreman_ansible-pull-request-1/gems/factory_bot-5.0.2/lib/factory_bot/find_definitions.rb:19:in `each'
	from /usr/local/rvm/gems/ruby-2.5.1@foreman_ansible-pull-request-1/gems/factory_bot-5.0.2/lib/factory_bot/find_definitions.rb:19:in `block in find_definitions'
	from /usr/local/rvm/gems/ruby-2.5.1@foreman_ansible-pull-request-1/gems/factory_bot-5.0.2/lib/factory_bot/find_definitions.rb:15:in `each'
	from /usr/local/rvm/gems/ruby-2.5.1@foreman_ansible-pull-request-1/gems/factory_bot-5.0.2/lib/factory_bot/find_definitions.rb:15:in `find_definitions'
	from /usr/local/rvm/gems/ruby-2.5.1@foreman_ansible-pull-request-1/gems/factory_bot-5.0.2/lib/factory_bot/reload.rb:6:in `reload'
	from /usr/local/rvm/gems/ruby-2.5.1@foreman_ansible-pull-request-1/gems/foreman_remote_execution-1.8.0/test/test_plugin_helper.rb:9:in `<top (required)>'
	from /usr/local/rvm/gems/ruby-2.5.1@foreman_ansible-pull-request-1/gems/foreman_remote_execution-1.8.0/test/functional/api/v2/foreign_input_sets_controller_test.rb:1:in `require'
	from /usr/local/rvm/gems/ruby-2.5.1@foreman_ansible-pull-request-1/gems/foreman_remote_execution-1.8.0/test/functional/api/v2/foreign_input_sets_controller_test.rb:1:in `<top (required)>'
	from /usr/local/rvm/gems/ruby-2.5.1@foreman_ansible-pull-request-1/gems/rake-12.3.2/lib/rake/rake_test_loader.rb:17:in `require'
	from /usr/local/rvm/gems/ruby-2.5.1@foreman_ansible-pull-request-1/gems/rake-12.3.2/lib/rake/rake_test_loader.rb:17:in `block in <main>'
	from /usr/local/rvm/gems/ruby-2.5.1@foreman_ansible-pull-request-1/gems/rake-12.3.2/lib/rake/rake_test_loader.rb:5:in `select'
	from /usr/local/rvm/gems/ruby-2.5.1@foreman_ansible-pull-request-1/gems/rake-12.3.2/lib/rake/rake_test_loader.rb:5:in `<main>'

@mmoll
Copy link
Contributor Author

mmoll commented May 28, 2019

Hm, that because rex tests are also running implicitly(?) here... So to get this green with the current mechanics, a new rex release would be required.

@mmoll
Copy link
Contributor Author

mmoll commented May 31, 2019

test failures unrelated, AFAICT

@ares
Copy link
Member

ares commented Jun 11, 2019

Thanks @mmoll, merging!

@ares ares merged commit f5b602a into theforeman:master Jun 11, 2019
This was referenced Jun 11, 2019
Merged
Merged
Merged
Merged
@adamruzicka adamruzicka mentioned this pull request Jul 4, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs testing Not yet reviewed
Projects
None yet
Milestone
No milestone
4 participants
@mmoll @tbrisker @ares @theforeman-bot