Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: catalog page composer #234

Merged
merged 2 commits into from
Nov 14, 2023
Merged

fix: catalog page composer #234

merged 2 commits into from
Nov 14, 2023

Conversation

ljiang-ti
Copy link
Contributor

@ljiang-ti ljiang-ti commented Nov 10, 2023 •
edited by chrisvariety

Resolves CLM-10156

Remove the reset params call when composing page urls.

chrisvariety
chrisvariety approved these changes Nov 10, 2023
View reviewed changes
Copy link
Member

@chrisvariety chrisvariety left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks much!! 🙏

@chrisvariety
Copy link
Member

@rjschill87 can you cut a release with this in it? thanks!

@rjschill87 rjschill87 merged commit 0cdbec7 into staging Nov 14, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisvariety chrisvariety chrisvariety approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ljiang-ti @chrisvariety @rjschill87