Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix option type definition to match usage. #1119

Merged
merged 12 commits into from Jan 9, 2020
7 changes: 7 additions & 0 deletions typings/commander-tests.ts
Expand Up @@ -37,6 +37,12 @@ function collect(val: string, memo: string[]) {
memo.push(val);
return memo;
}
/*
shadowspawn marked this conversation as resolved.
Show resolved Hide resolved
* Collector without return all so work
UrielCh marked this conversation as resolved.
Show resolved Hide resolved
*/
function collect2(val: string, memo: string[]) {
memo.push(val);
}

function increaseVerbosity(v: any, total: number) {
return total + 1;
Expand All @@ -51,6 +57,7 @@ program
.option('-l, --list <items>', 'A list', list)
.option('-o, --optional [value]', 'An optional value')
.option('-c, --collect [value]', 'A repeatable value', collect, [])
.option('--collect2 [value]', 'A repeatable value void return', collect2, [])
.option('-v, --verbose', 'A value that can be increased', increaseVerbosity, 0)
.parse(process.argv);

Expand Down
6 changes: 4 additions & 2 deletions typings/index.d.ts
Expand Up @@ -165,12 +165,14 @@ declare namespace commander {
*
* @param {string} flags
* @param {string} [description]
* @param {((arg1: any, arg2: any) => void) | RegExp} [fn] function or default
* @param {((value: string, previous: any) => void) | RegExp} [fn] function or default
UrielCh marked this conversation as resolved.
Show resolved Hide resolved
* @param {*} [defaultValue]
* @returns {Command} for chaining
*/
option(flags: string, description?: string, fn?: ((arg1: any, arg2: any) => void) | RegExp, defaultValue?: any): Command;
option(flags: string, description?: string, defaultValue?: any): Command;
UrielCh marked this conversation as resolved.
Show resolved Hide resolved
option(flags: string, description: string, regexp: RegExp, defaultValue?: any): Command;
option<T>(flags: string, description: string, fn: (value: string, previous: T) => (T | void), defaultValue?: T): Command;
option<T>(flags: string, description: string, fn: (value: string, previous: T) => void, defaultValue: T): Command;
shadowspawn marked this conversation as resolved.
Show resolved Hide resolved

/**
* Define a required option, which must have a value after parsing. This usually means
Expand Down