Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make new excess arguments error opt-in #1429

Merged
merged 6 commits into from Jan 7, 2021
Merged

Make new excess arguments error opt-in #1429

merged 6 commits into from Jan 7, 2021

Conversation

shadowspawn
Copy link
Collaborator

@shadowspawn shadowspawn commented Jan 3, 2021 •
edited

Pull Request

#1407 added support for an error for excess arguments and associated configuration, landing in 7.0.

Problem

Made the error the default behaviour in #1409. I am having second thoughts because:

  • other significant breaking changes in 7.0.0 making it harder to upgrade
  • get throws in unit tests where don't really care about correctly describing arguments
  • finding cause of unexpected throws in existing unit tests not always obvious

Solution

Make new error opt-in for now. (See if there is demand for error by-default in a future version.)

ChangeLog

ToDo

  • rework README (might wait for other PR to land)
  • rework CHANGELOG (might wait for other PR to land)
  • rethink example for custom-command-class as Command6 less interesting, which is a good sign

@shadowspawn shadowspawn added this to the v7.0.0 milestone Jan 3, 2021
@shadowspawn shadowspawn changed the base branch from master to release/7.x January 6, 2021 06:06
@shadowspawn shadowspawn mentioned this pull request Jan 7, 2021
Closed
@shadowspawn shadowspawn marked this pull request as ready for review January 7, 2021 22:53
@shadowspawn
Copy link
Collaborator Author

I have updated the docs and example, ready for review.

abetomo
abetomo approved these changes Jan 7, 2021
View reviewed changes
Copy link
Collaborator

@abetomo abetomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shadowspawn shadowspawn merged commit e2670f4 into tj:release/7.x Jan 7, 2021
@shadowspawn shadowspawn deleted the feature/excess-arguments-opt-in branch January 7, 2021 23:09
@shadowspawn shadowspawn added the pending release Merged into a branch for a future release, but not released yet label Jan 7, 2021
@shadowspawn
Copy link
Collaborator Author

Thanks @abetomo 🚀

@y1hao y1hao mentioned this pull request Jan 8, 2021
Merged
shadowspawn pushed a commit that referenced this pull request Jan 8, 2021
@y1hao
Feature/update chinese readme (#1431)
ff301fa 
* Update Chinese README to match release/7.x (#1420)

* Add Chinese versions of documents in the docs folder; update links in README (#1420)

* Update Chinese README: excess args error opt-in (#1420) (#1429)
@shadowspawn shadowspawn mentioned this pull request Jan 9, 2021
Closed
@shadowspawn shadowspawn removed the pending release Merged into a branch for a future release, but not released yet label Jan 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abetomo abetomo abetomo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v7.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shadowspawn @abetomo