Fix UDP loadbalancer tags not being used with Consul Catalog #9357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t3hchipmunk
changed the title
ldez
changed the title
ldez
added
status/2-needs-review
kind/bug/fix
mmatur
approved these changes
Sep 21, 2022
kevinpollet
changed the title
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes an issue of loadbalancer tags being used in Nomad jobs for Consul Catalog not picking up the port in the Consul Catalog addServerUDP. I used a lot of the addServerTCP code to realize the difference and correct for those differences.
Motivation
We recently ran into an issue of Traefik not picking up the port for our service written in Nomad using Consul Catalog (https://community.traefik.io/t/traefik-showing-port-0-for-service/15796). The port that Traefik would establish for the service was always 0. I was able to get it working by using a file configuration but that was insufficient for our use case as Nomad was in play.
More