Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v4: Mention GPU acceleration fix in docs callout #30811

Merged
merged 3 commits into from
Sep 24, 2020
Merged

v4: Mention GPU acceleration fix in docs callout #30811

merged 3 commits into from
Sep 24, 2020
+13 −0

Conversation

mdo
Copy link
Member

@mdo mdo commented May 14, 2020 •
edited by XhmikosR
Loading

@ffoodd
Copy link
Member

ffoodd commented May 14, 2020

Why not include the workaround right here?

@mdo
Copy link
Member Author

mdo commented May 14, 2020

Why not include the workaround right here?

Personally I hadn't tested it and wasn't sure if we'd want to include some JS snippet here. I'm down to do that though if folks would prefer it.

@XhmikosR
Copy link
Member

The snippet in #22610 (comment) assumes a bundler AFAICT. We need a snippet to cover all cases.

@mdo
Copy link
Member Author

mdo commented Jul 20, 2020 •
edited
Loading

If there's some suggested code or specific change to make here we can get it in, otherwise we have to punt this to another v4.x release. Thoughts @XhmikosR and @Johann-S?

@Johann-S
Copy link
Member

This snippet cover all cases @XhmikosR because if you import Popper.js with a <script> tag you'll be able to use Popper global variable.

so we can change it, to just that line:

Popper.Defaults.modifiers.computeStyle.gpuAcceleration = !(window.devicePixelRatio < 1.5 && /Win/.test(navigator.platform));

@XhmikosR
Copy link
Member

Cool, let's move the snippet to the docs and not link to an issue.

vanillajonathan
vanillajonathan reviewed Sep 22, 2020
View reviewed changes
site/docs/4.5/components/popovers.md Outdated
{% capture callout %}
##### GPU acceleration

Popovers sometimes appear blurry in Windows 10 devices due to GPU acceleration and a modified system DPI. The workaround for this in v4 is to disable GPU acceleration as needed on your popovers. [See this issue for details and a suggested fix](https://github.com/twbs/bootstrap/issues/22610).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"in Windows 10" or "on Windows 10 devices", but not "in Windows 10 devices".

@XhmikosR
Copy link
Member

@Johann-S can you push your proposed snippet to this branch please?

@Johann-S
Copy link
Member

done @XhmikosR 👍

mdo and others added 3 commits September 24, 2020 15:01
@mdo @XhmikosR
v4: Mention GPU acceleration fix in docs callout
a1dcf96 
Closes #22610
@XhmikosR
Update popovers.md
8cafda9
@Johann-S @XhmikosR
add suggested fix for gpu acceleration

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
2317ea7
@XhmikosR XhmikosR merged commit e45fbe7 into v4-dev Sep 24, 2020
@XhmikosR XhmikosR deleted the v4-popovers-gpu branch September 24, 2020 12:06
@XhmikosR XhmikosR mentioned this pull request Sep 24, 2020
Closed
@davidglezz davidglezz mentioned this pull request Oct 15, 2020
Closed
@nelsonni nelsonni mentioned this pull request Jan 5, 2021
Merged
@KostblLb
Copy link

Still reproduced on 4.6,
i also use @ng-bootstrap/ng-bootstrap@7.0.0, if it matters

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vanillajonathan vanillajonathan

@XhmikosR XhmikosR

Assignees
No one assigned
Labels
docs v4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@mdo @ffoodd @XhmikosR @Johann-S @KostblLb @vanillajonathan