Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V4 dev backports and updates #30836

Merged
merged 12 commits into from Jun 4, 2020
Merged

V4 dev backports and updates #30836

merged 12 commits into from Jun 4, 2020

Conversation

XhmikosR
Copy link
Member

@XhmikosR XhmikosR commented May 15, 2020

@XhmikosR XhmikosR added the v4 label May 15, 2020
@XhmikosR XhmikosR changed the title V4 dev backports V4 dev backports and updates May 18, 2020
@XhmikosR
Copy link
Member Author

XhmikosR commented May 18, 2020

@twbs/css-review I pushed a temp patch after dist for the floating labels example. Can you check if the IE/Edge workarounds are still fine?

@XhmikosR
Copy link
Member Author

XhmikosR commented Jun 4, 2020

So, can someone from @twbs/css-review check my comment above please? #30836 (comment)

The "Temp" commit is here: 593a63c

EDIT: also I need a confirmation about the word-break backport :)

@XhmikosR XhmikosR force-pushed the v4-dev-xmr branch 2 times, most recently from 8e2b03b to bc4ea2f Compare June 4, 2020 07:07
@ffoodd
Copy link
Member

ffoodd commented Jun 4, 2020

About the floating labels example, I'm a bit confused: there's an old patch for IE that seems to… break the example.

If I remove it, the example works fine in IE11 (tested on BrowserStack, W7 & W10).
However the Edge patch seems required. Both were introduced in #25919, but MDN compatibility table seems clear: IE10 & 11 did support their vendor version.

I'd be in favor of removing it (but should probably be another PR, souldn't it?).

For the .text-break class, I think overflow-wrap should be word-wrap. Am I right, @mdo?

@XhmikosR
Copy link
Member Author

XhmikosR commented Jun 4, 2020

I'd be in favor of removing it (but should probably be another PR, souldn't it?).

Yup, thanks for having a look.

For the .text-break class, I think overflow-wrap should be word-wrap. Am I right, @mdo?

I just reverted #30074 here.

Update to `@rollup/plugin-babel`
Restore word-break: break-word on .text-break to fix text breaking on flex containers
Add role="dialog" in modals via JavaScript
@XhmikosR XhmikosR marked this pull request as ready for review June 4, 2020 08:55
@XhmikosR XhmikosR merged commit 3caea1c into v4-dev Jun 4, 2020
@XhmikosR XhmikosR deleted the v4-dev-xmr branch June 4, 2020 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants