Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Use proper <button> instead of faked <a> element for popover example #31399

Closed
wants to merge 3 commits into from
Closed

Docs: Use proper <button> instead of faked <a> element for popover example #31399

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7f738b5
Docs: Use proper <button> instead of faked <a> element for popover ex…
patrickhlauke Aug 2, 2020
6b5a153
Merge branch 'main' into v5-docs-popover-tweak
XhmikosR Oct 1, 2020
8ad3580
Merge branch 'main' into v5-docs-popover-tweak
patrickhlauke Nov 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 1 addition & 2 deletions site/content/docs/5.0/components/popovers.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ For proper cross-browser and cross-platform behavior, you must use the `<a>` tag
{{< /callout >}}

{{< example >}}
<a tabindex="0" class="btn btn-lg btn-danger" role="button" data-bs-toggle="popover" data-bs-trigger="focus" title="Dismissible popover" data-bs-content="And here's some amazing content. It's very engaging. Right?">Dismissible popover</a>
<button type="button" class="btn btn-lg btn-danger" data-container="body" data-toggle="popover" data-trigger="focus" title="Dismissible popover" data-content="And here's some amazing content. It's very engaging. Right?">Dismissible popover</button>
{{< /example >}}

```js
Expand Down Expand Up @@ -301,7 +301,6 @@ Options for individual popovers can alternatively be specified through the use o
{{< partial "callout-danger-async-methods.md" >}}
{{< /callout >}}


#### show

Reveals an element's popover. **Returns to the caller before the popover has actually been shown** (i.e. before the `shown.bs.popover` event occurs). This is considered a "manual" triggering of the popover. Popovers whose title and content are both zero-length are never displayed.
Expand Down