Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Use proper <button> instead of faked <a> element for popover example #31399

Closed
wants to merge 3 commits into from

Conversation

patrickhlauke
Copy link
Member

sidesteps #31391 but on principle should really use <button> here

@patrickhlauke
Copy link
Member Author

patrickhlauke commented Aug 2, 2020

only browser that currently seems to have a problem with this, from testing, is Safari. investigating further what its beef is...

might set this to draft in meantime...wasn't expecting it to take that long, but seems the shortcoming/quirk there is not as straightforward as initially suspected.

@patrickhlauke patrickhlauke marked this pull request as draft August 2, 2020 19:22
@patrickhlauke
Copy link
Member Author

ok, root of the problem seems to be the fact that Safari doesn't actually focus elements like <button> when you click them with the mouse. which is ... not ideal https://twitter.com/patrick_h_lauke/status/1289988990146211840

and Firefox/Mac copied that silly behavior too. good good. considering adding some basic additional behavior that also sets focus() when clicking these controls...

@patrickhlauke
Copy link
Member Author

will likely keep this PR parked, do a separate PR for a potential cross-browser fix (or, well, a patch for Safari and Firefox on Mac), and hopefully this can then get merged when that fix is merged

@XhmikosR
Copy link
Member

@patrickhlauke do we close this?

@patrickhlauke
Copy link
Member Author

yeah as i get the feeling Apple are in no rush to change their behaviour in Safari (and Firefox will just copy what Safari does on macOS for "platform consistency"), and since I doubt we want to hack away at adding extra scripting that explicitly focuses the button after a click ... i think i'll just abandon this. annoying.

@XhmikosR XhmikosR deleted the v5-docs-popover-tweak branch November 24, 2020 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants