Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Removed LTS version #978

Merged
merged 3 commits into from Nov 9, 2023
Merged

chore: Removed LTS version #978

merged 3 commits into from Nov 9, 2023

Conversation

tiwarishubham635
Copy link
Contributor

@tiwarishubham635 tiwarishubham635 commented Nov 9, 2023

Fixes

Removed the LTS version from test and deploy pipeline as it was failing due to ongoing axios issue.
The Failed Run can be found here.
The Axios Issue can be found here

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

Copy link

sonarcloud bot commented Nov 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@shrutiburman
Copy link
Contributor

Please add the link of failed run/ axios issue, for future reference.

@tiwarishubham635
Copy link
Contributor Author

Please add the link of failed run/ axios issue, for future reference.

Done!

@tiwarishubham635 tiwarishubham635 merged commit e7bbeb1 into main Nov 9, 2023
14 checks passed
@tiwarishubham635 tiwarishubham635 deleted the remove_lts_version branch November 9, 2023 08:07
tiwarishubham635 added a commit that referenced this pull request Nov 9, 2023
* chore: Removed LTS version (#978)

* chore: removed LTS version

* chore: removing lts from cloudscan

* chore: completely removed LTS

* chore: Update axios to 1.6 to pull in fix for CVE 2023 45857 (#971)

* Update axios to 1.6.0

Fixes CVE-2023-45857

* Explicit type return on Promise

TypeScript's automatic type resolution for the promise returned by the
function in getExponentialBackoffResponseHandler determines that it
returns a Promise<unknown>. This commit forces TypeScript to recognize
that the resolved object is of type Promise<AxiosResponse>.

---------

Co-authored-by: Shubham <tiwarishubham635@gmail.com>

* chore: twilio help changes (#958)

Co-authored-by: Shubham <tiwarishubham635@gmail.com>

* chore: Removing Test Related To Deprecated Endpoint - OAuth (#963)

* removing test in relation to deprecated endpoint

* removingn more oauth refrences

---------

Co-authored-by: sbansla <104902068+sbansla@users.noreply.github.com>

---------

Co-authored-by: Andrew Pietila <149612764+kitu-apietila@users.noreply.github.com>
Co-authored-by: kridai <kridaigoswami@gmail.com>
Co-authored-by: KobeBrooks <55289738+KobeBrooks@users.noreply.github.com>
Co-authored-by: sbansla <104902068+sbansla@users.noreply.github.com>
tiwarishubham635 added a commit that referenced this pull request Nov 13, 2023
* chore: Removed LTS version (#978)

* chore: removed LTS version

* chore: removing lts from cloudscan

* chore: completely removed LTS

* chore: Update axios to 1.6 to pull in fix for CVE 2023 45857 (#971)

* Update axios to 1.6.0

Fixes CVE-2023-45857

* Explicit type return on Promise

TypeScript's automatic type resolution for the promise returned by the
function in getExponentialBackoffResponseHandler determines that it
returns a Promise<unknown>. This commit forces TypeScript to recognize
that the resolved object is of type Promise<AxiosResponse>.

---------

Co-authored-by: Shubham <tiwarishubham635@gmail.com>

* chore: twilio help changes (#958)

Co-authored-by: Shubham <tiwarishubham635@gmail.com>

* chore: Removing Test Related To Deprecated Endpoint - OAuth (#963)

* removing test in relation to deprecated endpoint

* removingn more oauth refrences

---------

Co-authored-by: sbansla <104902068+sbansla@users.noreply.github.com>

---------

Co-authored-by: Andrew Pietila <149612764+kitu-apietila@users.noreply.github.com>
Co-authored-by: kridai <kridaigoswami@gmail.com>
Co-authored-by: KobeBrooks <55289738+KobeBrooks@users.noreply.github.com>
Co-authored-by: sbansla <104902068+sbansla@users.noreply.github.com>
@tiwarishubham635 tiwarishubham635 mentioned this pull request Dec 26, 2023
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants