Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OracleDriver :: Add Schema Option #6133

Closed
wants to merge 1 commit into from
Closed

OracleDriver :: Add Schema Option #6133

wants to merge 1 commit into from

Conversation

pirouet
Copy link
Contributor

@pirouet pirouet commented May 26, 2020

Currently OracleDriver does not respect the schema option provided in the Entity decorator. This change is a simple one to add it to the list of Drivers that will have the schema set

@liudonghua123
Copy link

The format of the code changed a lot, maybe preserve the original format, or make another pr about the format.

@pirouet
Copy link
Contributor Author

pirouet commented Sep 5, 2020

Hi, change of format is unintentional but the way my styling is in the IDE.

I'll probably need to can this merge and create a new one. When are you looking to do a merge and push new version? This change would be ideal to have available for my Production apps

Loving the work 😁

@pirouet
Copy link
Contributor Author

pirouet commented Sep 5, 2020

Superseded by #6673. Closing this down - other change is the same but without changing the formatting

@pirouet pirouet closed this Sep 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants