test(eslint-plugin): add tests for generic type params

typescript-eslint · Sep 4, 2019 · 9cbe4d8 · 9cbe4d8
1 parent 0719da8
commit 9cbe4d8
Showing 1 changed file with 15 additions and 0 deletions.
diff --git a/packages/eslint-plugin/tests/rules/no-unnecessary-condition.test.ts b/packages/eslint-plugin/tests/rules/no-unnecessary-condition.test.ts
@@ -54,6 +54,12 @@ const t1 = (b1 && b2) ? 'yes' : 'no'`,
     necessaryConditionTest('any'), // any
     necessaryConditionTest('unknown'), // unknown
 
+    // Generic type params
+    `
+function test<T extends string>(t: T) {
+  return t ? 'yes' : 'no'
+}`,
+
     // Supports ignoring the RHS
     {
       code: `
@@ -94,6 +100,15 @@ const t1 = (b1 && b2) ? 'yes' : 'no'`,
     unnecessaryConditionTest('void', 'alwaysFalsy'),
     unnecessaryConditionTest('never', 'never'),
 
+    // Generic type params
+    {
+      code: `
+function test<T extends object>(t: T) {
+  return t ? 'yes' : 'no'
+}`,
+      errors: [ruleError(3, 10, 'alwaysTruthy')],
+    },
+
     // Still errors on in the expected locations when ignoring RHS
     {
       options: [{ ignoreRhs: true }],