Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(eslint-plugin): remove ignoreRHS from no-unnecessary-condition #2052

Merged
merged 3 commits into from May 21, 2020
Merged

Conversation

0xCLARITY
Copy link
Contributor

This was removed from the actual code in this PR:
#1163

This was removed from the actual code in this PR:
#1163
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @hbergren!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@0xCLARITY 0xCLARITY changed the title Remove ignoreRHS from no-unnecessary-condition documentation docs: Remove ignoreRHS from no-unnecessary-condition May 21, 2020
@bradzacher bradzacher added the documentation Documentation ("docs") that needs adding/updating label May 21, 2020
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops - thanks for catching this!

@bradzacher bradzacher changed the title docs: Remove ignoreRHS from no-unnecessary-condition docs(eslint-plugin): remove ignoreRHS from no-unnecessary-condition May 21, 2020
@codecov
Copy link

codecov bot commented May 21, 2020

Codecov Report

Merging #2052 into master will decrease coverage by 0.28%.
The diff coverage is 79.60%.

@@            Coverage Diff             @@
##           master    #2052      +/-   ##
==========================================
- Coverage   93.68%   93.40%   -0.29%     
==========================================
  Files         172      171       -1     
  Lines        7871     7745     -126     
  Branches     2263     2210      -53     
==========================================
- Hits         7374     7234     -140     
- Misses        233      246      +13     
- Partials      264      265       +1     
Flag Coverage Δ
#unittest 93.40% <79.60%> (-0.29%) ⬇️
Impacted Files Coverage Δ
...gin-internal/src/rules/no-poorly-typed-ts-props.ts 88.88% <ø> (ø)
packages/eslint-plugin/src/rules/ban-ts-comment.ts 100.00% <ø> (ø)
packages/eslint-plugin/src/rules/comma-spacing.ts 97.77% <ø> (ø)
...int-plugin/src/rules/consistent-type-assertions.ts 86.48% <ø> (ø)
...-plugin/src/rules/explicit-function-return-type.ts 100.00% <ø> (ø)
...plugin/src/rules/explicit-module-boundary-types.ts 82.60% <ø> (ø)
...kages/eslint-plugin/src/rules/func-call-spacing.ts 96.87% <ø> (ø)
...n/src/rules/indent-new-do-not-use/OffsetStorage.ts 100.00% <ø> (ø)
.../eslint-plugin/src/rules/member-delimiter-style.ts 94.44% <ø> (ø)
...kages/eslint-plugin/src/rules/naming-convention.ts 88.51% <ø> (ø)
... and 64 more

@bradzacher bradzacher merged commit 23b4b66 into typescript-eslint:master May 21, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Documentation ("docs") that needs adding/updating
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants