Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(eslint-plugin): remove ignoreRHS from no-unnecessary-condition #2052

Merged
merged 3 commits into from May 21, 2020
Merged

docs(eslint-plugin): remove ignoreRHS from no-unnecessary-condition #2052

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1aa6f1c
Remove `ignoreRHS` from `no-unnecessary-condition` documentation
0xCLARITY May 21, 2020
b44467b
Merge branch 'master' into patch-1
bradzacher May 21, 2020
28731ae
Merge branch 'master' into patch-1
bradzacher May 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 0 additions & 8 deletions packages/eslint-plugin/docs/rules/no-unnecessary-condition.md
View file
Open in desktop
Expand Up @@ -64,14 +64,6 @@ function bar(arg?: string | null) {

Accepts an object with the following options:

- `ignoreRhs` (default `false`) - doesn't check if the right-hand side of `&&` and `||` is a necessary condition. For example, the following code is valid with this option on:

```ts
function head<T>(items: T[]) {
return items.length && items[0].toUpperCase();
}
```

- `allowConstantLoopConditions` (default `false`) - allows constant expressions in loops.

Example of correct code for when `allowConstantLoopConditions` is `true`:
Expand Down