New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v4.0.0 breaking changes #2330
v4.0.0 breaking changes #2330
Commits on Aug 29, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 17edfeb - Browse repository at this point
Copy the full SHA 17edfebView commit details -
Configuration menu - View commit details
-
Copy full SHA for c4dd244 - Browse repository at this point
Copy the full SHA c4dd244View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0ce7302 - Browse repository at this point
Copy the full SHA 0ce7302View commit details -
Configuration menu - View commit details
-
Copy full SHA for dc03300 - Browse repository at this point
Copy the full SHA dc03300View commit details -
feat(eslint-plugin): [ban-ts-comment] change default for `ts-expect-e…
Configuration menu - View commit details
-
Copy full SHA for 7081320 - Browse repository at this point
Copy the full SHA 7081320View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0276347 - Browse repository at this point
Copy the full SHA 0276347View commit details -
Configuration menu - View commit details
-
Copy full SHA for 26e2155 - Browse repository at this point
Copy the full SHA 26e2155View commit details -
fix: correct decorator traversal for AssignmentPattern (#2375)
BREAKING CHANGE: - Removed decorators property from several Nodes that could never semantically have them (FunctionDeclaration, TSEnumDeclaration, and TSInterfaceDeclaration) - Removed AST_NODE_TYPES.Import. This is a minor breaking change as the node type that used this was removed ages ago.
Configuration menu - View commit details
-
Copy full SHA for 3c2625a - Browse repository at this point
Copy the full SHA 3c2625aView commit details -
fix(typescript-estree): correct ChainExpression interaction with pare…
…ntheses and non-nulls (#2380)
Configuration menu - View commit details
-
Copy full SHA for 89404f9 - Browse repository at this point
Copy the full SHA 89404f9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 73d605d - Browse repository at this point
Copy the full SHA 73d605dView commit details -
feat(eslint-plugin): [no-unnecessary-condition][strict-boolean-expres…
…sions] add option to make the rules error on files without `strictNullChecks` turned on (#2345)
Configuration menu - View commit details
-
Copy full SHA for f5adf22 - Browse repository at this point
Copy the full SHA f5adf22View commit details -
feat(typescript-estree): switch to globby (#2418)
Fixes #2398 If the user has a particularly large node_modules folder and uses globs for `parserOption.project`, then the `glob` library can spend a decent chunk of time searching the `node_modules` folder. In some cases, this can be on the order of hundreds to thousands of milliseconds. This wouldn't be a problem, but for safety and correctness during a persistent parse, we have to do this check for every call to the parser (i.e. every file that's being linted). Over a whole project, this can easily add up to many, many seconds wasted. Previously, we: - applied the project globs, one by one - then manually excluded `tsconfig`s from the list. This meant that we are always slow. I remember I did this because I had issues getting `glob`'s `ignore` option to work at all. ## The solution `globby` is a better glob library: - it accepts an array of globs, which saves us doing manual looping - it supports exclusion globs (globs prefixed with `!`), which are evaluated as part of the glob process - it has caching built in by default This allows us to evaluate all of the `project` globs at once, as opposed to one at a time (so should be less duplicated work). This also allows us to evaluate the `projectFolderIgnoreList` at the same time as the `project` globs (so should be no useless work done). All of these together should cut the glob evaluation time down to ~50ms for the first parse, and ~2ms for each parse after that (due to caching). For comparison, previously, in bad cases we would spend ~3-500ms, per project, per parsed file. Example to illustrate how much faster this can potentially be: For a project that provides 2 globs and has 100 files. Before: 300ms * 2 * 100 = 60,000ms (60s) After: 50ms + 2 * 100 = 250ms This should also save a non-trival amount of time in other, more optimal setups. BREAKING CHANGE: - removes the ability to supply a `RegExp` to `projectFolderIgnoreList`, and changes the meaning of the string value from a regex to a glob.
Configuration menu - View commit details
-
Copy full SHA for 2c632c1 - Browse repository at this point
Copy the full SHA 2c632c1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 63c8d09 - Browse repository at this point
Copy the full SHA 63c8d09View commit details -
Configuration menu - View commit details
-
Copy full SHA for 497adb9 - Browse repository at this point
Copy the full SHA 497adb9View commit details -
Configuration menu - View commit details
-
Copy full SHA for a257183 - Browse repository at this point
Copy the full SHA a257183View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2a75bb1 - Browse repository at this point
Copy the full SHA 2a75bb1View commit details