v4.0.0 breaking changes

.all-contributorsrc

@@ -100,6 +100,13 @@
       "profile": "https://github.com/Retsam",
       "contributions": []
     },
+    {
+      "login": "yeonjuan",
+      "name": "YeonJuan",
+      "avatar_url": "https://avatars3.githubusercontent.com/u/41323220?v=4",
+      "profile": "https://github.com/yeonjuan",
+      "contributions": []
+    },
     {
       "login": "kaicataldo",
       "name": "Kai Cataldo",
@@ -128,13 +135,6 @@
       "profile": "https://github.com/azz",
       "contributions": []
     },
-    {
-      "login": "yeonjuan",
-      "name": "YeonJuan",
-      "avatar_url": "https://avatars3.githubusercontent.com/u/41323220?v=4",
-      "profile": "https://github.com/yeonjuan",
-      "contributions": []
-    },
     {
       "login": "dannyfritz",
       "name": "Danny Fritz",
@@ -177,6 +177,13 @@
       "profile": "https://github.com/anikethsaha",
       "contributions": []
     },
+    {
+      "login": "octogonz",
+      "name": "Pete Gonzalez",
+      "avatar_url": "https://avatars0.githubusercontent.com/u/4673363?v=4",
+      "profile": "https://github.com/octogonz",
+      "contributions": []
+    },
     {
       "login": "ldrick",
       "name": "Ricky Lippmann",
@@ -191,6 +198,13 @@
       "profile": "https://github.com/SimenB",
       "contributions": []
     },
+    {
+      "login": "cherryblossom000",
+      "name": "cherryblossom000",
+      "avatar_url": "https://avatars2.githubusercontent.com/u/31467609?v=4",
+      "profile": "https://github.com/cherryblossom000",
+      "contributions": []
+    },
     {
       "login": "vapurrmaid",
       "name": "G r e y",
@@ -233,13 +247,6 @@
       "profile": "https://github.com/pablobirukov",
       "contributions": []
     },
-    {
-      "login": "octogonz",
-      "name": "Pete Gonzalez",
-      "avatar_url": "https://avatars0.githubusercontent.com/u/4673363?v=4",
-      "profile": "https://github.com/octogonz",
-      "contributions": []
-    },
     {
       "login": "mightyiam",
       "name": "Shahar Dawn Or",
@@ -330,13 +337,6 @@
       "avatar_url": "https://avatars2.githubusercontent.com/u/296735?v=4",
       "profile": "https://github.com/madbence",
       "contributions": []
-    },
-    {
-      "login": "dependabot[bot]",
-      "name": "dependabot[bot]",
-      "avatar_url": "https://avatars0.githubusercontent.com/in/29110?v=4",
-      "profile": "https://github.com/apps/dependabot",
-      "contributions": []
     }
   ],
   "contributorsPerLine": 5

.cspell.json

@@ -77,6 +77,8 @@
     "Premade",
     "prettier's",
     "recurse",
+    "redeclaration",
+    "redeclarations",
     "redeclared",
     "reimplement",
     "resync",
@@ -92,7 +94,8 @@
     "typedef",
     "typedefs",
     "unfixable",
-    "unprefixed"
+    "unprefixed",
+    "Zacher"
   ],
   "overrides": [
     {

.eslintrc.js

@@ -214,6 +214,7 @@ module.exports = {
         'packages/eslint-plugin-internal/tests/rules/**/*.test.ts',
         'packages/eslint-plugin-tslint/tests/rules/**/*.test.ts',
         'packages/eslint-plugin/tests/rules/**/*.test.ts',
+        'packages/eslint-plugin/tests/eslint-rules/**/*.test.ts',
       ],
       rules: {
         '@typescript-eslint/internal/plugin-test-formatting': 'error',

.github/workflows/ci.yml

@@ -4,6 +4,8 @@ on:
   push:
     branches:
       - master
+      # TODO - delete this before merging v4 into master
+      - v4
   pull_request:
     branches:
       - '**'
@@ -348,3 +350,48 @@ jobs:
         run: npx lerna publish --loglevel=verbose --canary --exact --force-publish --yes
         env:
           NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
+
+  # TODO - delete this before merging v4 into master
+  publish_v4_prerelease_version:
+    name: Publish the latest code as a v4 prerelease version
+    runs-on: ubuntu-latest
+    needs: [typecheck, test_on_primary_node_version, unit_tests_on_other_node_versions, linting_and_style, integration_tests]
+    if: github.ref == 'refs/heads/v4'
+    steps:
+      - uses: actions/checkout@v2
+      # Fetch all history for all tags and branches in this job because lerna needs it
+      - run: |
+          git fetch --prune --unshallow
+
+      - name: Use Node.js ${{ env.PRIMARY_NODE_VERSION }}
+        uses: actions/setup-node@v1
+        with:
+          node-version: ${{ env.PRIMARY_NODE_VERSION }}
+          registry-url: https://registry.npmjs.org/
+
+      - name: Get yarn cache directory path
+        id: yarn-cache-dir-path
+        run: echo "::set-output name=dir::$(yarn cache dir)"
+
+      - uses: actions/cache@v1
+        id: yarn-cache # use this to check for `cache-hit` (`steps.yarn-cache.outputs.cache-hit != 'true'`)
+        with:
+          path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
+          key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }}
+          restore-keys: |
+            ${{ runner.os }}-yarn-
+
+      - name: Install dependencies
+        run: |
+          yarn --ignore-engines --frozen-lockfile --ignore-scripts
+          yarn lerna:init
+          yarn check:clean-workspace-after-install
+
+      - name: Build
+        run: |
+          yarn build
+
+      - name: Publish all packages to npm
+        run: npx lerna publish premajor --loglevel=verbose --canary --exact --force-publish --yes --dist-tag rc-v4
+        env:
+          NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}