Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-plugin): add extension rule comma-dangle #2416

Merged
merged 9 commits into from Sep 21, 2020
Merged

feat(eslint-plugin): add extension rule comma-dangle #2416

merged 9 commits into from Sep 21, 2020

Conversation

yeonjuan
Copy link
Contributor

fixes #710

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @yeonjuan!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented Aug 23, 2020

Codecov Report

Merging #2416 into master will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2416   +/-   ##
=======================================
  Coverage   92.82%   92.82%           
=======================================
  Files         290      291    +1     
  Lines        9506     9551   +45     
  Branches     2664     2676   +12     
=======================================
+ Hits         8824     8866   +42     
- Misses        323      324    +1     
- Partials      359      361    +2     
Flag Coverage Δ
#unittest 92.82% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/eslint-plugin/src/configs/all.ts 100.00% <ø> (ø)
packages/eslint-plugin/src/rules/comma-dangle.ts 93.33% <ø> (ø)

@yeonjuan yeonjuan dismissed a stale review via b3b1588 August 23, 2020 05:33
@bradzacher bradzacher added the enhancement: new base rule extension New base rule extension required to handle a TS specific case label Aug 23, 2020
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly lgtm! typo in the docs

packages/eslint-plugin/docs/rules/comma-dangle.md Outdated Show resolved Hide resolved
@bradzacher bradzacher added the awaiting response Issues waiting for a reply from the OP or another party label Aug 24, 2020
Co-authored-by: Brad Zacher <brad.zacher@gmail.com>
@yeonjuan
Copy link
Contributor Author

yeonjuan commented Aug 24, 2020

typo in the docs

@bradzacher Oh. it's my bad. Thanks :)

@bradzacher bradzacher removed the awaiting response Issues waiting for a reply from the OP or another party label Aug 24, 2020
# Conflicts:
#	packages/eslint-plugin/README.md
@ashlinchak

This comment has been minimized.

@bradzacher
Copy link
Member

https://github.com/typescript-eslint/typescript-eslint/blob/master/CONTRIBUTING.md#addressing-feedback-and-beyond

When I've got time to review larger feature PRs, I'll get to it.
I've been swamped the last few weeks with the v4 release and the fixes that were required for it.

Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for your contribution!

@bradzacher bradzacher merged commit f7babcf into typescript-eslint:master Sep 21, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement: new base rule extension New base rule extension required to handle a TS specific case
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[comma-dangle] does not check enum declarations
3 participants