Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(eslint-plugin): [prefer-nullish-coalescing] add ignoreTernaryTests option #4965
feat(eslint-plugin): [prefer-nullish-coalescing] add ignoreTernaryTests option #4965
Changes from 17 commits
a07ac2d
0487bb7
33a6053
b7b0758
42e9737
61b9680
40609b1
e9626e9
81f1a1d
060002a
a20e741
ee6bbf6
0726c9d
c4146c0
65415e6
dda02a3
cafa047
8ee505c
119f14d
31966ff
3d0eab1
73034b0
4ef1ef7
3b36d89
67e7ab5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: this name is a little non-specific. Maybe...
There's almost certainly a better name out there than
doNodesContainSameValue
, so that's just a starting thought.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will think about this one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have thought about this, I don't like
doNodesContainSameValue
since we don't just compare the contents or value.I however also have no idea for a better name 🤷♂️