Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make class-validator a peer dependency #472

Closed

Conversation

sincraianul
Copy link

closes #384

It makes sense to have class-validator as a peer dependency since routing-controllers is not really relying on it to provide certain standalone functionalities, but rather executes code from class-validator on the developer's part.

@matthewlilley
Copy link

It would be appreciated if you can accept this PR, or make a commit to achieve this yourselves. This causes problems when using class validator in other areas of an application.

@sincraianul
Copy link
Author

sincraianul commented May 10, 2019

@matthewlilley FIY I've transitioned to NestJS in the meantime, as this repo doesn't seem to be actively supported.

@matthewlilley
Copy link

matthewlilley commented May 10, 2019

@sincraianul Thanks for that. NestJS looks impressive, and resembles a popular PHP rad framework. That's something I believe the JS eco-system has been desperately needing for some time.

This wasn't a blocker for me, I just rolled back to the same version of class validator as this package is using, however, it would be nice to not be locked into using this version.

@elthrasher elthrasher mentioned this pull request Sep 29, 2019
@jotamorais
Copy link
Member

Fixed and merged through #512

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Routing-Controllers + class-validator bug?
4 participants