-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated dependencies #512
updated dependencies #512
Conversation
Amazingly, I barely had to touch any code or tests. We now have 100% updated dependencies and |
@elthrasher Thanks for your PR. I don't think there will be any major problems either but I'm testing with a big project I'm currently working on (I think it will be a good "test ground"). |
@jotamorais I did some testing too and looks to me like breaking changes in |
Yeah, let's do it. Then we can test the whole thing using peer dependencies and make sure it won't have any undesired effect. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@elthrasher
I've tested more with the project I mentioned before and everything seems to still work just fine after updating dependencies and moving class-transformer
and class-validator
to peer dependencies.
Additionally, I've also tested [routing-controllers-openapi](https://github.com/epiphone/routing-controllers-openapi#readme)
and it also worked like a charm.
Thanks for your contributions and PR.
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
The build/test/publish system for this repo is a bit outdated and many dependencies are out of date. It looks like the build and tests still work, but that gulpfile isn't working for me. I think the best bet is to just remove it and replace with npm scripts.
@jotamorais I was very happy to see that you were taking over maintenance of this project. Should I continue with this effort?