Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

was [always] called with [exactly]: console.warn an error on the first invocation #86

Merged
merged 1 commit into from Jan 19, 2019

Conversation

papandreou
Copy link
Member

@papandreou papandreou commented Jan 19, 2019

As discussed on #32

@papandreou papandreou self-assigned this Jan 19, 2019
@coveralls
Copy link

coveralls commented Jan 19, 2019

Coverage Status

Coverage increased (+0.04%) to 95.745% when pulling f1abaa5 on chore/deprecateWasCalledWith into 550b961 on master.

"unexpected-sinon: The 'was [always] called with [exactly]' assertion is deprecated.\nPlease use 'to have a call satisfying' instead:\n" +
'http://unexpected.js.org/unexpected-sinon/assertions/spy/to-have-a-call-satisfying/'
);
deprecationWarningDisplayed = true;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice touch.

Copy link
Member

@sunesimonsen sunesimonsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@papandreou papandreou merged commit 0bb5d60 into master Jan 19, 2019
@papandreou papandreou deleted the chore/deprecateWasCalledWith branch January 19, 2019 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants