Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: new LogLevel enum is not exported properly #95 #96

Merged
merged 2 commits into from May 7, 2020
Merged

fix: new LogLevel enum is not exported properly #95 #96

merged 2 commits into from May 7, 2020

Conversation

regevbr
Copy link
Contributor

@regevbr regevbr commented May 7, 2020

fix #95

@regevbr
Copy link
Contributor Author

regevbr commented May 7, 2020

@pi0 @Atinux can you please CR this?
This is kind of "urgent" as the current release will break for who ever is using typescript :-(

@regevbr regevbr mentioned this pull request May 7, 2020
Closed
pi0
pi0 reviewed May 7, 2020
View reviewed changes
package.json Outdated
@@ -20,7 +20,6 @@
"release": "standard-version && yarn build && git push --follow-tags && npm publish"
},
"files": [
"src",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing this is breaking change for 2.x (#51)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So should I remove it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never mind I removed it, the critical fix here is not related to it

@pi0 pi0 merged commit fafbec2 into unjs:master May 7, 2020
@pi0
Copy link
Member

pi0 commented May 7, 2020

Thanks for quick fix @regevbr 👍 v2.12.1 released. Anyway will rewrite lib with typescript for next major so we don't have typing issues and also one dist in package.

@regevbr regevbr deleted the #95 branch May 7, 2020 14:44
@regevbr
Copy link
Contributor Author

regevbr commented May 7, 2020

sounds good. Thanks for the quick response! I will try it now to see everything works properly

@regevbr
Copy link
Contributor Author

regevbr commented May 7, 2020

I can confirm everything works great in Node :-)

nevilm-lt pushed a commit to nevilm-lt/consola that referenced this pull request Apr 22, 2022
@regevbr @nevilm-lt
fix: new LogLevel enum is not exported properly unjs#95 (unjs#96)
cbb8143
himanshiLt pushed a commit to himanshiLt/consola that referenced this pull request Jun 20, 2022
@regevbr @himanshiLt
fix: new LogLevel enum is not exported properly unjs#95 (unjs#96)
20073f8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: new LogLevel enum is not exported properly
2 participants
@regevbr @pi0