Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: several bugfixes for generated urls #114

Merged
merged 5 commits into from
Aug 27, 2023
Merged

fix: several bugfixes for generated urls #114

merged 5 commits into from
Aug 27, 2023

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Aug 27, 2023

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

We were not handling many cases of difference between local-only / anyhost and a specific network interface IP listening causing misleading console output...

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codecov
Copy link

codecov bot commented Aug 27, 2023

Codecov Report

Merging #114 (d14eb18) into main (d671382) will increase coverage by 0.42%.
The diff coverage is 77.65%.

❗ Current head d14eb18 differs from pull request most recent head f8259b3. Consider uploading reports for the commit f8259b3 to get more accurate results

@@            Coverage Diff             @@
##             main     #114      +/-   ##
==========================================
+ Coverage   51.12%   51.55%   +0.42%     
==========================================
  Files          10       10              
  Lines        1639     1670      +31     
  Branches      122      128       +6     
==========================================
+ Hits          838      861      +23     
- Misses        801      809       +8     
Files Changed Coverage Ξ”
src/_utils.ts 57.50% <75.60%> (-2.72%) ⬇️
src/listen.ts 82.33% <79.24%> (+2.40%) ⬆️

@pi0 pi0 merged commit 9bc3135 into main Aug 27, 2023
2 checks passed
@pi0 pi0 deleted the fix/url-listing branch August 27, 2023 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant