Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix order mismatch #90

Merged
merged 1 commit into from
Aug 6, 2023
Merged

test: fix order mismatch #90

merged 1 commit into from
Aug 6, 2023

Conversation

Mastercuber
Copy link
Contributor

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This PR fixes an order miss match of the variables used in 2 tests. The check should actually check if the certificate is signed with the CA, and not if the CA is signed with the certificate, since the CA is self signed.

@codecov
Copy link

codecov bot commented Aug 6, 2023

Codecov Report

Merging #90 (410075e) into main (b05fa84) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #90   +/-   ##
=======================================
  Coverage   49.85%   49.85%           
=======================================
  Files          10       10           
  Lines        1410     1410           
  Branches      101      101           
=======================================
  Hits          703      703           
  Misses        707      707           

@pi0 pi0 changed the title fix(test): order miss match test: fix order mismatch Aug 6, 2023
@pi0 pi0 merged commit 43e0a3c into unjs:main Aug 6, 2023
4 checks passed
@pi0
Copy link
Member

pi0 commented Aug 6, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants