feat: add parseNodeModulePath and lookupNodeModuleSubpath utils
#89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
Codecov Report
@@ Coverage Diff @@
## main #89 +/- ##
==========================================
+ Coverage 85.89% 86.99% +1.09%
==========================================
Files 8 8
Lines 865 1007 +142
Branches 134 167 +33
==========================================
+ Hits 743 876 +133
- Misses 122 131 +9
|
|
Sorry i kinda forgot to check this. Do you mind to add some basic tests? |
pi0
force-pushed
the
feat/resolve-subpath
branch
from
d688cec
to
865c217
Compare
pi0
changed the title
parseNodeModulePath and lookupNodeModuleSubpath utils
|
@danielroe Do you mind to review my last changes? |
|
Looks good to me! 鉂わ笍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.