Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support esbuild option charset #190

Closed
wants to merge 2 commits into from
Closed

feat: support esbuild option charset #190

wants to merge 2 commits into from

Conversation

ntnyq
Copy link
Contributor

@ntnyq ntnyq commented Jan 1, 2023 •
edited

ci is failed because eslint lint error.

By default esbuild's output is ASCII-only. Setting the charset explicitly can disable character escaping.

Refs:

@ntnyq ntnyq changed the title ci: fix lint error feat: support esbuild option charset Jan 1, 2023
@yjl9903 yjl9903 mentioned this pull request Mar 1, 2023
Merged
pi0
pi0 approved these changes Mar 27, 2023
View reviewed changes
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think we might default it to utf8 as well it makes sense other places use utf8 encoding...

pi0 pushed a commit that referenced this pull request Mar 27, 2023
@ntnyq @pi0
feat: support esbuild charset option (#190)
9186985
@pi0
Copy link
Member

pi0 commented Mar 27, 2023

merged via 9186985

@pi0 pi0 closed this Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ntnyq @pi0