Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: copy source maps for frontend resources #12701

Merged
merged 1 commit into from Jan 13, 2022

Conversation

vursen
Copy link
Contributor

@vursen vursen commented Jan 12, 2022

Description

This PR fixes TaskCopyFrontendFiles so that it copies source maps for frontend resources as well.

Related to #12574

Type of change

  • Bugfix

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

@CLAassistant
Copy link

CLAassistant commented Jan 12, 2022

CLA assistant check
All committers have signed the CLA.

@vursen vursen force-pushed the fix/move-source-maps-to-frontend-dest branch from 7a42d25 to dd80380 Compare January 12, 2022 09:42
@github-actions
Copy link

github-actions bot commented Jan 12, 2022

Unit Test Results

   769 files  ±0     769 suites  ±0   24m 11s ⏱️ +2s
5 742 tests ±0  5 690 ✔️  - 1  52 💤 +1  0 ±0 
5 774 runs   - 4  5 721 ✔️  - 5  53 💤 +1  0 ±0 

Results for commit 7569e03. ± Comparison against base commit bcf4b12.

♻️ This comment has been updated with latest results.

@vursen vursen force-pushed the fix/move-source-maps-to-frontend-dest branch from dd80380 to 7569e03 Compare January 12, 2022 10:25
@sonarcloud
Copy link

sonarcloud bot commented Jan 12, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@platosha platosha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

I’d suggest that we also merge this in 2.7, 2.8 and 9.0 branches, as this is something potentially useful with webpack (and source-map-loader) also.

Added the target/... labels here for automatic cherry picking.

@vursen vursen merged commit 2eaf26f into master Jan 13, 2022
@vursen vursen deleted the fix/move-source-maps-to-frontend-dest branch January 13, 2022 07:21
@vaadin-bot
Copy link
Collaborator

Hi @vursen and @vursen, when i performed cherry-pick to this commit to 2.8, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick 2eaf26f
error: could not apply 2eaf26f... fix: copy source maps for frontend resources (#12701)
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add ' or 'git rm '
hint: and commit the result with 'git commit'

@vaadin-bot
Copy link
Collaborator

Hi @vursen and @vursen, when i performed cherry-pick to this commit to 2.7, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick 2eaf26f
error: could not apply 2eaf26f... fix: copy source maps for frontend resources (#12701)
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add ' or 'git rm '
hint: and commit the result with 'git commit'

@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with platform 23.0.0.alpha3 and is also targeting the upcoming stable 23.0.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants