Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JWKs #105

Closed
wants to merge 3 commits into from
Closed

JWKs #105

wants to merge 3 commits into from

Conversation

tanner0101
Copy link
Member

@tanner0101 tanner0101 commented Oct 23, 2019 •
edited

add JWKs support to JWT 3.0

Moving vapor/jwt-kit#97 here

@tanner0101 tanner0101 added the enhancement New feature or request label Oct 23, 2019
@tanner0101 tanner0101 added this to In Progress in Vapor 3 via automation Oct 23, 2019
@tanner0101 tanner0101 changed the base branch from 3 to master October 23, 2019 01:10
@tanner0101 tanner0101 changed the title 3 jwks JWKs Oct 23, 2019
@tanner0101
Copy link
Member Author

Hmm.. it seems like at some point master was merged back into @valeriomazzeo's fork with a nasty merge conflict. All JWT and JWTKit source is appearing in the same package.

@valeriomazzeo could you cherry pick vapor/jwt-kit@c4aaa00 as a new PR into vapor/jwt-kit:3 ? I would do it but I don't wanna take Git author cred for your work.

@tanner0101 tanner0101 closed this Oct 23, 2019
Vapor 3 automation moved this from In Progress to Done Oct 23, 2019
@tanner0101 tanner0101 mentioned this pull request Oct 23, 2019
Merged
@tanner0101 tanner0101 deleted the 3-jwks branch October 23, 2019 01:14
@valeriomazzeo
Copy link
Contributor

I have reverted that master merge. This is the PR as it was originally intended for Vapor 3 vapor/jwt-kit#106 .

Just as a reminder I had already implemented this for Vapor 2, but for whatever reason it wasn't ported to Vapor 3.

It would be nice if you could please incorporate this feature also in the master branch, for Vapor 4. Otherwise I will have to re-implement it once again :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
No open projects
Vapor 3
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tanner0101 @valeriomazzeo