New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added JWK and JWKS support #97
Conversation
Typo in Doc-Block Comment (I suppose)
Is there anything I can do this get this PR merged? I would love to see this integrated, however the PR is open already half a year. |
@dehlen you can use https://github.com/asensei/vapor-auth-jwt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for missing this earlier, we should consider adding JWK support to the next major release (currently in alpha).
The module has been renamed from JWT
to JWTKit
, so these files must be moved. Besides that, it seems like everything here should work against the latest version on master.
|
||
class JWKTests: XCTestCase { | ||
|
||
static let allTests = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of supplying an allTests
array, just run swift test --generate-linuxmain
before committing.
Great to see things coming along. I am currently using a fork for this to work and love to be able to use the stable version here with the next release. Again I am not the author of the pull request but if there is anything I can help with... |
@tanner0101 as this PR was for 3.0, why not merge it there and release it as 3.1.0? |
@vzsg we definitely could. It's currently targeted at master which is 4.0, but I'd be happy to merge into branch Looking at Swift at least, they usually merge things into master (unstable), then cherry pick to the respective stable versions they would like to support. |
Well, back in November 2018 when this PR was opened, master was still 3.0 :) |
@tanner0101 be careful when merging into |
@tanner0101 is this going to be merged into master soon? |
@tanner0101 Any update on this PR? Starting development on a major application, and we could really use this :) |
@amkomatz the content of this pull request is included in https://github.com/asensei/vapor-auth-jwt We've been using this since Vapor 2. |
Merging this into |
Update on the situation here: vapor/jwt-kit#105 (comment) |
I have reverted that Just as a reminder I had already implemented this for Vapor 2, but for whatever reason it wasn't ported to Vapor 3. It would be nice if you could please incorporate this feature also in the |
Added in JWT 3.1.0, thanks @valeriomazzeo! https://github.com/vapor/jwt-kit/releases/tag/3.1.0 |
JWK added to master branch here: vapor/jwt-kit#107 |
This pull request adds support for JWK and JWKS.
It fixes #87
Note: only RSA keys have been implemented so far.