Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use runIfActive instead of submit in async passwords #2340

Merged
merged 1 commit into from Apr 30, 2020
Merged

Use runIfActive instead of submit in async passwords #2340

merged 1 commit into from Apr 30, 2020

Conversation

jdmcd
Copy link
Member

@jdmcd jdmcd commented Apr 30, 2020

Replaces the use of threadPool.submit { _ in with threadPool.runIfActive as detailed in vapor/docs#478

@jdmcd jdmcd mentioned this pull request Apr 30, 2020
Merged
@0xTim 0xTim added the semver-patch Internal changes only label Apr 30, 2020
0xTim
0xTim approved these changes Apr 30, 2020
View reviewed changes
Copy link
Member

@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@0xTim 0xTim merged commit 47ad53a into master Apr 30, 2020
@0xTim 0xTim deleted the async-password branch April 30, 2020 17:32
@tanner0101
Copy link
Member

These changes are now available in 4.4.1

@tanner0101 tanner0101 added this to Awaiting Review in Vapor 4 via automation Apr 30, 2020
@tanner0101 tanner0101 added the bug Something isn't working label Apr 30, 2020
@tanner0101 tanner0101 moved this from Awaiting Review to Done in Vapor 4 Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xTim 0xTim 0xTim approved these changes

Assignees
No one assigned
Labels
bug Something isn't working semver-patch Internal changes only
Projects
Vapor 4
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jdmcd @tanner0101 @0xTim