Patch configuration and log actual port on startup

[bisgardo]

These changes are now available in 4.94.1

Before this change, the application

let app = Application(.testing)
defer { app.shutdown() }
try app.server.start(hostname: nil, port: 0)
defer { app.server.shutdown() }

would log the following message before starting the server:

[Vapor] Server starting on http://127.0.0.1:0

After this change it instead logs a message like the following after starting the server:

[Vapor] Server starting on http://127.0.0.1:57935

The input configuration is also patched such that app.http.server.configuration.port will hold the actual port after startup. Currently if it has value 0 it will keep that value (only app.http.server.shared.localAddress?.port will have the correct one).

Fixes #3159.

[bisgardo]

I have no experience with this code base so I'm just guessing that it's safe to force unwrap self.localAddress after the server has successfully started.

I also realize that the log message is now less readable and doesn't include the protocol. This was just the simplest possible solution I could come up with. I'll be happy to change it.

Looking forward to your feedback.

[0xTim]

Thanks! Just a couple of nits left

[bisgardo]

Ping @0xTim :)

[bisgardo]

@0xTim Is there anything that needs to change before this can get merged? If you disagree with extracting addressDescription I can inline it, no problem.

[0xTim]

One minor change then good to go!

[0xTim]

Sorry one last thing to add - can you add a test for the configuration? Essentially run the server set to port 0 and then try and read the port from the configuration and make sure it isn't 0

[0xTim]

Thanks!

[0xTim]

@bisgardo the new test is failing

[bisgardo]

@bisgardo the new test is failing

It was an existing test, not the new one. I've pushed a fix.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.44%. Comparing base (11cdb29) to head (10d373b).
Report is 9 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3160      +/-   ##
==========================================
+ Coverage   76.86%   77.44%   +0.57%     
==========================================
  Files         211      210       -1     
  Lines        8119     7822     -297     
==========================================
- Hits         6241     6058     -183     
+ Misses       1878     1764     -114     

Files	Coverage Δ
Sources/Vapor/HTTP/Server/HTTPServer.swift	95.85% <100.00%> (+15.08%)	⬆️

... and 92 files with indirect coverage changes