Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch configuration and log actual port on startup #3160

Merged
merged 12 commits into from Apr 26, 2024

Commits on Mar 13, 2024

  1. Log actual port on startup

    Before this change, the application
    
    ```swift
    let app = Application(.testing)
    defer { app.shutdown() }
    try app.server.start(hostname: nil, port: 0)
    defer { app.server.shutdown() }
    ```
    
    would log the following message *before* starting the server:
    
    ```
    [Vapor] Server starting on http://127.0.0.1:0
    ```
    
    After this change it instead logs a message like the following *after* starting the server:
    
    ```
    [Vapor] Server started on [IPv4]127.0.0.1/127.0.0.1:57935
    ```
    bisgardo committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    18eabbd View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2024

  1. Avoid changing log format

    bisgardo committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    85887e2 View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2024

  1. Configuration menu
    Copy the full SHA
    f08b69d View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2024

  1. Make 'addressDescription' a computed property

    Just invoking the property twice seemed cleaner to me compared to duplicating the code block. Fixed a little indentation issue in the process
    
    I don't know if it's ever relevant, but config is now patched on all address types, including unix socket.
    bisgardo committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    eb2dc75 View commit details
    Browse the repository at this point in the history
  2. Remove obsolete variable

    bisgardo committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    32949ff View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2024

  1. Configuration menu
    Copy the full SHA
    b7b6c8a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    056f621 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2024

  1. Add test

    bisgardo committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    dac9901 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5f45d7f View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2024

  1. Fix broken test

    bisgardo committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    bee515e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    cf376b6 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2024

  1. Configuration menu
    Copy the full SHA
    10d373b View commit details
    Browse the repository at this point in the history