Skip to content

4.89.2 - Consistently use the value from `X-Request-Id` as the request's ID when present
Compare
Choose a tag to compare
@penny-for-vapor penny-for-vapor released this 13 Dec 13:06
· 41 commits to main since this release
4.89.2
9c830d4
This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Learn about vigilant mode.

What's Changed

Consistently use the value from X-Request-Id as the request's ID when present by @baarde in #3117

Changes

This PR ensures that the Request’s id and the value of the logger’s request-id value are the same.

Motivation

The Request’s id property was added in #2964 to expose the request-id identifier used for logging.

#3072 changed this behavior. The request-id identifier is now set:

  • to the value from the X-Request-Id header, when the header is present,
  • to a random identifier, when the header is absent.

Having two different identifiers is confusing. So, this PR reconciles the two values.

History

The first version of this PR allowed the two identifiers to differ when the X-Request-Id header is present, in order to maintain the original semantics of the id property.

New Contributor

Reviewers

Thanks to the reviewers for their help:

This patch was released by @0xTim

Full Changelog: 4.89.1...4.89.2

Contributors

baarde, 0xTim, and MahdiBM
Assets 2