4.89.3 - Fix setting public folder for `FileMiddleware` when using bundles
What's Changed
Fix setting public folder for FileMiddleware
when using bundles by @grantjbutler in #3113
This PR fixes an issue where, if you provided a subfolder within a bundleβs resources, the wrong path would be provided to the
FileMiddleware
, causing the resources to not be loaded.For example, given a bundle with the following structure:
App.app/ βββ Contents/ βββ MacOS/ β βββ App βββ Resources/ βββ web-app/ βββ Public βββ index.html
If you tried to create an instance of
FileMiddleware
that tried to useweb-app/Public/
as the folder to serve files from,FileMiddleware
would incorrectly use the resource path of the bundle (App.app/Resources/
) instead of the full path to the specified folder (App.app/Resources/web-app/Public/
).
New Contributor
- @grantjbutler made their first contribution in #3113 π
This patch was released by @gwynne
Full Changelog: 4.89.2...4.89.3