New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: allow for normalizedNumberFormat
for stack: "normalize"
tooltips
#8303
Conversation
Note: this PR will either need to rebase if #8302 is merged first, or vice versa. |
Looking at the code more, it's also worth noting that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add some tests so codecov won't complain?
Closing in favor of #8307 |
This PR addresses #8300. As mentioned in the referenced issue, the spelling of the
normalizedNumberFormat
field may be subject to change (per feedback of @domoritz @jheer).Important: The
normalizedNumberFormat
should only be applied to tooltips that arestack: "normalize"
. Furthermore, this PR intentionally does not implement thenormalizedNumberFormat[Type]
encoding forsrc/compile/legend/encode.ts
because @kanitw and I could not think of a non positional situation wherestack
is used.