Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: swap 'mouse' events to 'pointer' events for mobile compatibility; update site and docs #9089

Merged
merged 128 commits into from
Oct 4, 2023
Merged

feat: swap 'mouse' events to 'pointer' events for mobile compatibility; update site and docs #9089

merged 128 commits into from
Oct 4, 2023

Conversation

alliefeldman
Copy link
Contributor

  • Site examples now use ‘pointer’ events instead of mouse events; all other elements of examples remain unchanged
  • Update ‘site/docs/’ to include ‘pointer’ events
  • All site examples use ‘pointer’ instead of ‘mouse’ in the instances of -over, -move, -out, -down, -up
  • Unit tests include pointer events
  • All lint and unit tests pass

@alliefeldman alliefeldman reopened this Sep 15, 2023
@domoritz
Copy link
Member

Can you add feat: to the title?

@alliefeldman alliefeldman changed the title Swap 'mouse' events to 'pointer' events for mobile compatibility; update site and docs feat: swap 'mouse' events to 'pointer' events for mobile compatibility; update site and docs Sep 15, 2023
@alliefeldman
Copy link
Contributor Author

Done!

domoritz
domoritz requested changes Sep 19, 2023
View reviewed changes
Copy link
Member

@domoritz domoritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please clean up the pull request. Otherwise looks good.

site/_data/versions.yml Outdated Show resolved Hide resolved
site/.ruby-version Outdated Show resolved Hide resolved
site/= Outdated Show resolved Hide resolved
site/Gemfile.lock Outdated Show resolved Hide resolved
site/docs/parameter/select.md Show resolved Hide resolved
src/compile/selection/interval.ts Outdated Show resolved Hide resolved
src/compile/selection/interval.ts Outdated Show resolved Hide resolved
test-runtime/index.html Show resolved Hide resolved
domoritz
domoritz requested changes Sep 22, 2023
View reviewed changes
Copy link
Member

@domoritz domoritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please look over the pull request more carefully. There are a lot of cahnges that should not be included.

Icon Outdated Show resolved Hide resolved
build/vega-lite-schema.json Outdated Show resolved Hide resolved
examples/specs/concat_hover_filter.vl.json Outdated Show resolved Hide resolved
site/Gemfile.lock Outdated Show resolved Hide resolved
site/= Outdated Show resolved Hide resolved
src/channeldef.ts Outdated Show resolved Hide resolved
src/channeldef.ts Outdated Show resolved Hide resolved
src/encoding.ts Outdated Show resolved Hide resolved
src/selection.ts Outdated Show resolved Hide resolved
test-runtime/index.html Show resolved Hide resolved
domoritz
domoritz requested changes Sep 22, 2023
View reviewed changes
Copy link
Member

@domoritz domoritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please look over the pull request more carefully. There are a lot of cahnges that should not be included.

@alliefeldman alliefeldman reopened this Sep 25, 2023
@alliefeldman alliefeldman marked this pull request as draft September 25, 2023 20:39
@alliefeldman alliefeldman marked this pull request as ready for review September 25, 2023 21:17
domoritz
domoritz requested changes Oct 4, 2023
View reviewed changes
Copy link
Member

@domoritz domoritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete the versions file as well.

examples/specs/interactive_line_point_hover.vl.json
"size": {
"condition": {"test": {"param": "hover", "empty": false}, "value": 48},
"value": 100
"mark": "line"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's leave the indentation as it was before.

domoritz
domoritz reviewed Oct 4, 2023
View reviewed changes
.gitignore Outdated Show resolved Hide resolved
@domoritz domoritz self-requested a review October 4, 2023 19:55
@domoritz domoritz marked this pull request as ready for review October 4, 2023 19:55
@domoritz domoritz merged commit fa97659 into vega:main Oct 4, 2023
7 checks passed
This was referenced Oct 4, 2023
Closed
Open
BradyJ27 pushed a commit to BradyJ27/vega-lite that referenced this pull request Oct 19, 2023
@alliefeldman @BradyJ27
feat: swap 'mouse' events to 'pointer' events for mobile compatibilit…
cb6f3be 
…y; update site and docs (vega#9089)
alliefeldman added a commit to alliefeldman/vega-lite that referenced this pull request Nov 2, 2023
@alliefeldman
feat: swap 'mouse' events to 'pointer' events for mobile compatibilit…
b50a706 
…y; update site and docs (vega#9089)
@joelostblom joelostblom mentioned this pull request Mar 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domoritz domoritz domoritz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@alliefeldman @domoritz @lsh @kanitw @jonmmease