Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 'move' cursor added over brush mark #9132

Closed
wants to merge 30 commits into from

Conversation

alliefeldman
Copy link
Contributor

To create affordance for brush panning, switch the user's mouse cursor to 'move' when dragging/hovering over a displayed interval selection.

Screenshot 2023-10-11 at 11 27 21 AM

Contributes to #4155

alliefeldman and others added 22 commits August 7, 2023 14:32
…(interpolatedSignalRef) (vega#9111)

Co-authored-by: GitHub Actions Bot <vega-actions-bot@users.noreply.github.com>
Bumps [jest-dev-server](https://github.com/argos-ci/jest-puppeteer/tree/HEAD/packages/jest-dev-server) from 9.0.0 to 9.0.1.
- [Release notes](https://github.com/argos-ci/jest-puppeteer/releases)
- [Changelog](https://github.com/argos-ci/jest-puppeteer/blob/main/packages/jest-dev-server/CHANGELOG.md)
- [Commits](https://github.com/argos-ci/jest-puppeteer/commits/v9.0.1/packages/jest-dev-server)

---
updated-dependencies:
- dependency-name: jest-dev-server
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) from 7.22.20 to 7.23.0.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.23.0/packages/babel-core)

---
updated-dependencies:
- dependency-name: "@babel/core"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [terser](https://github.com/terser/terser) from 5.19.4 to 5.20.0.
- [Changelog](https://github.com/terser/terser/blob/master/CHANGELOG.md)
- [Commits](terser/terser@v5.19.4...v5.20.0)

---
updated-dependencies:
- dependency-name: terser
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@arvind
Copy link
Member

arvind commented Oct 11, 2023

This is an exciting contribution! As we work through the feature and associated PRs, I thought I'd offer one gut check (which you may have already thought of and done, but just in case): not all interval selections will necessarily be pannable/zoomable (i.e., users may choose to set translate or zoom to false). Thus, it may make more sense for cursors to be properties of the translate/zoom selection compilers (e.g., hooking into the marks callback and making cursor overrides as need be) than to have them be situated in the interval selection compiler/config (as I think this PR is currently proposing—though I may be mistaken).

@alliefeldman alliefeldman reopened this Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants