Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the jest-circus test runner #12974

Merged
merged 9 commits into from May 16, 2020
Merged

Use the jest-circus test runner #12974

merged 9 commits into from May 16, 2020

Conversation

Janpot
Copy link
Contributor

@Janpot Janpot commented May 16, 2020

Attempt at using the jest-circus test runner, which will become the default in jest 27. This allows for usage of jest.retryTimes as a potential remedy against some of the test flakyness.

Issues that came up so far:

  • jest-circus deprecates jasmine so all usage of jasmine.DEFAULT_TIMEOUT_INTERVAL has to be replaced with jest.setTimeout.
  • looks like errors in afterAll now fail the test suite. There was a missing parameter here and here and here. It's supposed to be afterAll(() => killApp(app)).
  • conformance suite tries to kill a server that isn't initialized.
  • EPERM errors in create-next-app suite. Looks like jest.setTimeout only applies to beforeAll now if it's called in there, I moved it top-level in the suite. I also refactored these tests to be idempotent so that retries don't fail.

Just be aware: I've set retryTimes at 3 for all the suites. This shouldn't be problematic unless there are some tests that are not idempotent.

@ijjk
Copy link
Member

ijjk commented May 16, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
zeit/next.js canary Janpot/next.js jest-circus Change
buildDuration 9.4s 9.7s ⚠️ +314ms
nodeModulesSize 58.3 MB 58.3 MB
Page Load Tests Overall decrease ⚠️
zeit/next.js canary Janpot/next.js jest-circus Change
/ failed reqs 0 0
/ total time (seconds) 1.585 1.566 -0.02
/ avg req/sec 1577.14 1596.62 ⚠️ +19.48
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 0.918 0.968 ⚠️ +0.05
/error-in-render avg req/sec 2723.35 2582.6 -140.75
Client Bundles (main, webpack, commons)
zeit/next.js canary Janpot/next.js jest-circus Change
main-HASH.js gzip 6.68 kB 6.68 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..e49d.js gzip 10.4 kB 10.4 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57 kB 57 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary Janpot/next.js jest-circus Change
main-HASH.module.js gzip 5.72 kB 5.72 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.85 kB 6.85 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 52.5 kB 52.5 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary Janpot/next.js jest-circus Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB
Overall change 26.3 kB 26.3 kB
Client Pages
zeit/next.js canary Janpot/next.js jest-circus Change
_app.js gzip 1.26 kB 1.26 kB
_error.js gzip 3.28 kB 3.28 kB
hooks.js gzip 881 B 881 B
index.js gzip 222 B 222 B
link.js gzip 2.06 kB 2.06 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 8.26 kB 8.26 kB
Client Pages Modern
zeit/next.js canary Janpot/next.js jest-circus Change
_app.module.js gzip 604 B 604 B
_error.module.js gzip 2.09 kB 2.09 kB
hooks.module.js gzip 383 B 383 B
index.module.js gzip 223 B 223 B
link.module.js gzip 1.52 kB 1.52 kB
routerDirect..dule.js gzip 281 B 281 B
withRouter.m..dule.js gzip 278 B 278 B
Overall change 5.38 kB 5.38 kB
Client Build Manifests
zeit/next.js canary Janpot/next.js jest-circus Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Rendered Page Sizes
zeit/next.js canary Janpot/next.js jest-circus Change
index.html gzip 925 B 925 B
link.html gzip 936 B 936 B
withRouter.html gzip 922 B 922 B
Overall change 2.78 kB 2.78 kB

Serverless Mode
General
zeit/next.js canary Janpot/next.js jest-circus Change
buildDuration 10.9s 10.9s -38ms
nodeModulesSize 58.3 MB 58.3 MB
Client Bundles (main, webpack, commons)
zeit/next.js canary Janpot/next.js jest-circus Change
main-HASH.js gzip 6.68 kB 6.68 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..e49d.js gzip 10.4 kB 10.4 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57 kB 57 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary Janpot/next.js jest-circus Change
main-HASH.module.js gzip 5.72 kB 5.72 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.85 kB 6.85 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 52.5 kB 52.5 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary Janpot/next.js jest-circus Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB
Overall change 26.3 kB 26.3 kB
Client Pages
zeit/next.js canary Janpot/next.js jest-circus Change
_app.js gzip 1.26 kB 1.26 kB
_error.js gzip 3.28 kB 3.28 kB
hooks.js gzip 881 B 881 B
index.js gzip 222 B 222 B
link.js gzip 2.06 kB 2.06 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 8.26 kB 8.26 kB
Client Pages Modern
zeit/next.js canary Janpot/next.js jest-circus Change
_app.module.js gzip 604 B 604 B
_error.module.js gzip 2.09 kB 2.09 kB
hooks.module.js gzip 383 B 383 B
index.module.js gzip 223 B 223 B
link.module.js gzip 1.52 kB 1.52 kB
routerDirect..dule.js gzip 281 B 281 B
withRouter.m..dule.js gzip 278 B 278 B
Overall change 5.38 kB 5.38 kB
Client Build Manifests
zeit/next.js canary Janpot/next.js jest-circus Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Serverless bundles
zeit/next.js canary Janpot/next.js jest-circus Change
_error.js 850 kB 850 kB
404.html 4.18 kB 4.18 kB
hooks.html 3.81 kB 3.81 kB
index.js 851 kB 851 kB
link.js 888 kB 888 kB
routerDirect.js 880 kB 880 kB
withRouter.js 880 kB 880 kB
Overall change 4.36 MB 4.36 MB

@ijjk
Copy link
Member

ijjk commented May 16, 2020

Failing test suites

test/integration/invalid-href/test/index.test.js

Expand output

● Test suite failed to run

TypeError: Cannot read property 'pid' of undefined

  263 | export async function killApp(instance) {
  264 |   await new Promise((resolve, reject) => {
> 265 |     treeKill(instance.pid, err => {
      |                       ^
  266 |       if (err) {
  267 |         if (
  268 |           process.platform === 'win32' &&

  at lib/next-test-utils.js:265:23
  at killApp (lib/next-test-utils.js:264:9)
  at integration/invalid-href/test/index.test.js:146:20

test/integration/conformance/test/index.test.js

Expand output

● Test suite failed to run

TypeError: Cannot read property 'pid' of undefined

  263 | export async function killApp(instance) {
  264 |   await new Promise((resolve, reject) => {
> 265 |     treeKill(instance.pid, err => {
      |                       ^
  266 |       if (err) {
  267 |         if (
  268 |           process.platform === 'win32' &&

  at lib/next-test-utils.js:265:23
  at killApp (lib/next-test-utils.js:264:9)
  at integration/conformance/test/index.test.js:18:18

@ijjk
Copy link
Member

ijjk commented May 16, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
zeit/next.js canary Janpot/next.js jest-circus Change
buildDuration 11.2s 11.3s ⚠️ +152ms
nodeModulesSize 58.3 MB 58.3 MB
Page Load Tests Overall increase ✓
zeit/next.js canary Janpot/next.js jest-circus Change
/ failed reqs 0 0
/ total time (seconds) 1.849 1.884 ⚠️ +0.03
/ avg req/sec 1352.16 1326.93 -25.23
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.117 1.078 -0.04
/error-in-render avg req/sec 2238.14 2318.16 ⚠️ +80.02
Client Bundles (main, webpack, commons)
zeit/next.js canary Janpot/next.js jest-circus Change
main-HASH.js gzip 6.68 kB 6.68 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..e49d.js gzip 10.4 kB 10.4 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57 kB 57 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary Janpot/next.js jest-circus Change
main-HASH.module.js gzip 5.72 kB 5.72 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.85 kB 6.85 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 52.5 kB 52.5 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary Janpot/next.js jest-circus Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB
Overall change 26.3 kB 26.3 kB
Client Pages
zeit/next.js canary Janpot/next.js jest-circus Change
_app.js gzip 1.26 kB 1.26 kB
_error.js gzip 3.28 kB 3.28 kB
hooks.js gzip 881 B 881 B
index.js gzip 222 B 222 B
link.js gzip 2.06 kB 2.06 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 8.26 kB 8.26 kB
Client Pages Modern
zeit/next.js canary Janpot/next.js jest-circus Change
_app.module.js gzip 604 B 604 B
_error.module.js gzip 2.09 kB 2.09 kB
hooks.module.js gzip 383 B 383 B
index.module.js gzip 223 B 223 B
link.module.js gzip 1.52 kB 1.52 kB
routerDirect..dule.js gzip 281 B 281 B
withRouter.m..dule.js gzip 278 B 278 B
Overall change 5.38 kB 5.38 kB
Client Build Manifests
zeit/next.js canary Janpot/next.js jest-circus Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Rendered Page Sizes
zeit/next.js canary Janpot/next.js jest-circus Change
index.html gzip 925 B 925 B
link.html gzip 936 B 936 B
withRouter.html gzip 922 B 922 B
Overall change 2.78 kB 2.78 kB

Serverless Mode
General
zeit/next.js canary Janpot/next.js jest-circus Change
buildDuration 12.1s 12s -159ms
nodeModulesSize 58.3 MB 58.3 MB
Client Bundles (main, webpack, commons)
zeit/next.js canary Janpot/next.js jest-circus Change
main-HASH.js gzip 6.68 kB 6.68 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..e49d.js gzip 10.4 kB 10.4 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57 kB 57 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary Janpot/next.js jest-circus Change
main-HASH.module.js gzip 5.72 kB 5.72 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.85 kB 6.85 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 52.5 kB 52.5 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary Janpot/next.js jest-circus Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB
Overall change 26.3 kB 26.3 kB
Client Pages
zeit/next.js canary Janpot/next.js jest-circus Change
_app.js gzip 1.26 kB 1.26 kB
_error.js gzip 3.28 kB 3.28 kB
hooks.js gzip 881 B 881 B
index.js gzip 222 B 222 B
link.js gzip 2.06 kB 2.06 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 8.26 kB 8.26 kB
Client Pages Modern
zeit/next.js canary Janpot/next.js jest-circus Change
_app.module.js gzip 604 B 604 B
_error.module.js gzip 2.09 kB 2.09 kB
hooks.module.js gzip 383 B 383 B
index.module.js gzip 223 B 223 B
link.module.js gzip 1.52 kB 1.52 kB
routerDirect..dule.js gzip 281 B 281 B
withRouter.m..dule.js gzip 278 B 278 B
Overall change 5.38 kB 5.38 kB
Client Build Manifests
zeit/next.js canary Janpot/next.js jest-circus Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Serverless bundles
zeit/next.js canary Janpot/next.js jest-circus Change
_error.js 850 kB 850 kB
404.html 4.18 kB 4.18 kB
hooks.html 3.81 kB 3.81 kB
index.js 851 kB 851 kB
link.js 888 kB 888 kB
routerDirect.js 880 kB 880 kB
withRouter.js 880 kB 880 kB
Overall change 4.36 MB 4.36 MB

@ijjk
Copy link
Member

ijjk commented May 16, 2020

Failing test suites

test/integration/conformance/test/index.test.js

Expand output

● Test suite failed to run

TypeError: Cannot read property 'pid' of undefined

  263 | export async function killApp(instance) {
  264 |   await new Promise((resolve, reject) => {
> 265 |     treeKill(instance.pid, err => {
      |                       ^
  266 |       if (err) {
  267 |         if (
  268 |           process.platform === 'win32' &&

  at lib/next-test-utils.js:265:23
  at killApp (lib/next-test-utils.js:264:9)
  at integration/conformance/test/index.test.js:18:18

@ijjk
Copy link
Member

ijjk commented May 16, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
zeit/next.js canary Janpot/next.js jest-circus Change
buildDuration 12.2s 12.2s ⚠️ +30ms
nodeModulesSize 58.5 MB 58.5 MB
Page Load Tests Overall decrease ⚠️
zeit/next.js canary Janpot/next.js jest-circus Change
/ failed reqs 0 0
/ total time (seconds) 2.132 2.225 ⚠️ +0.09
/ avg req/sec 1172.58 1123.81 -48.77
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.386 1.453 ⚠️ +0.07
/error-in-render avg req/sec 1803.12 1720.43 -82.69
Client Bundles (main, webpack, commons)
zeit/next.js canary Janpot/next.js jest-circus Change
main-HASH.js gzip 6.68 kB 6.68 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..e49d.js gzip 10.4 kB 10.4 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57 kB 57 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary Janpot/next.js jest-circus Change
main-HASH.module.js gzip 5.72 kB 5.72 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.85 kB 6.85 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 52.5 kB 52.5 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary Janpot/next.js jest-circus Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB
Overall change 26.3 kB 26.3 kB
Client Pages
zeit/next.js canary Janpot/next.js jest-circus Change
_app.js gzip 1.26 kB 1.26 kB
_error.js gzip 3.28 kB 3.28 kB
hooks.js gzip 881 B 881 B
index.js gzip 222 B 222 B
link.js gzip 2.06 kB 2.06 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 8.26 kB 8.26 kB
Client Pages Modern
zeit/next.js canary Janpot/next.js jest-circus Change
_app.module.js gzip 604 B 604 B
_error.module.js gzip 2.09 kB 2.09 kB
hooks.module.js gzip 383 B 383 B
index.module.js gzip 223 B 223 B
link.module.js gzip 1.52 kB 1.52 kB
routerDirect..dule.js gzip 281 B 281 B
withRouter.m..dule.js gzip 278 B 278 B
Overall change 5.38 kB 5.38 kB
Client Build Manifests
zeit/next.js canary Janpot/next.js jest-circus Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Rendered Page Sizes
zeit/next.js canary Janpot/next.js jest-circus Change
index.html gzip 925 B 925 B
link.html gzip 936 B 936 B
withRouter.html gzip 922 B 922 B
Overall change 2.78 kB 2.78 kB

Serverless Mode
General
zeit/next.js canary Janpot/next.js jest-circus Change
buildDuration 13.2s 13.2s -54ms
nodeModulesSize 58.5 MB 58.5 MB
Client Bundles (main, webpack, commons)
zeit/next.js canary Janpot/next.js jest-circus Change
main-HASH.js gzip 6.68 kB 6.68 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..e49d.js gzip 10.4 kB 10.4 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57 kB 57 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary Janpot/next.js jest-circus Change
main-HASH.module.js gzip 5.72 kB 5.72 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.85 kB 6.85 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 52.5 kB 52.5 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary Janpot/next.js jest-circus Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB
Overall change 26.3 kB 26.3 kB
Client Pages
zeit/next.js canary Janpot/next.js jest-circus Change
_app.js gzip 1.26 kB 1.26 kB
_error.js gzip 3.28 kB 3.28 kB
hooks.js gzip 881 B 881 B
index.js gzip 222 B 222 B
link.js gzip 2.06 kB 2.06 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 8.26 kB 8.26 kB
Client Pages Modern
zeit/next.js canary Janpot/next.js jest-circus Change
_app.module.js gzip 604 B 604 B
_error.module.js gzip 2.09 kB 2.09 kB
hooks.module.js gzip 383 B 383 B
index.module.js gzip 223 B 223 B
link.module.js gzip 1.52 kB 1.52 kB
routerDirect..dule.js gzip 281 B 281 B
withRouter.m..dule.js gzip 278 B 278 B
Overall change 5.38 kB 5.38 kB
Client Build Manifests
zeit/next.js canary Janpot/next.js jest-circus Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Serverless bundles
zeit/next.js canary Janpot/next.js jest-circus Change
_error.js 850 kB 850 kB
404.html 4.18 kB 4.18 kB
hooks.html 3.81 kB 3.81 kB
index.js 851 kB 851 kB
link.js 888 kB 888 kB
routerDirect.js 880 kB 880 kB
withRouter.js 880 kB 880 kB
Overall change 4.36 MB 4.36 MB

@ijjk
Copy link
Member

ijjk commented May 16, 2020

Failing test suites

test/integration/conformance/test/index.test.js

Expand output

● Test suite failed to run

TypeError: Cannot read property 'pid' of undefined

  263 | export async function killApp(instance) {
  264 |   await new Promise((resolve, reject) => {
> 265 |     treeKill(instance.pid, err => {
      |                       ^
  266 |       if (err) {
  267 |         if (
  268 |           process.platform === 'win32' &&

  at lib/next-test-utils.js:265:23
  at killApp (lib/next-test-utils.js:264:9)
  at integration/conformance/test/index.test.js:18:18

@ijjk
Copy link
Member

ijjk commented May 16, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
zeit/next.js canary Janpot/next.js jest-circus Change
buildDuration 11.6s 12.8s ⚠️ +1.2s
nodeModulesSize 58.5 MB 58.5 MB
Page Load Tests Overall increase ✓
zeit/next.js canary Janpot/next.js jest-circus Change
/ failed reqs 0 0
/ total time (seconds) 1.95 2.004 ⚠️ +0.05
/ avg req/sec 1281.77 1247.67 -34.1
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.165 1.141 -0.02
/error-in-render avg req/sec 2146.07 2190.42 ⚠️ +44.35
Client Bundles (main, webpack, commons)
zeit/next.js canary Janpot/next.js jest-circus Change
main-HASH.js gzip 6.68 kB 6.68 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..e49d.js gzip 10.4 kB 10.4 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57 kB 57 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary Janpot/next.js jest-circus Change
main-HASH.module.js gzip 5.72 kB 5.72 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.85 kB 6.85 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 52.5 kB 52.5 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary Janpot/next.js jest-circus Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB
Overall change 26.3 kB 26.3 kB
Client Pages
zeit/next.js canary Janpot/next.js jest-circus Change
_app.js gzip 1.26 kB 1.26 kB
_error.js gzip 3.28 kB 3.28 kB
hooks.js gzip 881 B 881 B
index.js gzip 222 B 222 B
link.js gzip 2.06 kB 2.06 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 8.26 kB 8.26 kB
Client Pages Modern
zeit/next.js canary Janpot/next.js jest-circus Change
_app.module.js gzip 604 B 604 B
_error.module.js gzip 2.09 kB 2.09 kB
hooks.module.js gzip 383 B 383 B
index.module.js gzip 223 B 223 B
link.module.js gzip 1.52 kB 1.52 kB
routerDirect..dule.js gzip 281 B 281 B
withRouter.m..dule.js gzip 278 B 278 B
Overall change 5.38 kB 5.38 kB
Client Build Manifests
zeit/next.js canary Janpot/next.js jest-circus Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Rendered Page Sizes
zeit/next.js canary Janpot/next.js jest-circus Change
index.html gzip 925 B 925 B
link.html gzip 936 B 936 B
withRouter.html gzip 922 B 922 B
Overall change 2.78 kB 2.78 kB

Serverless Mode
General
zeit/next.js canary Janpot/next.js jest-circus Change
buildDuration 12.6s 12.6s ⚠️ +28ms
nodeModulesSize 58.5 MB 58.5 MB
Client Bundles (main, webpack, commons)
zeit/next.js canary Janpot/next.js jest-circus Change
main-HASH.js gzip 6.68 kB 6.68 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..e49d.js gzip 10.4 kB 10.4 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57 kB 57 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary Janpot/next.js jest-circus Change
main-HASH.module.js gzip 5.72 kB 5.72 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.85 kB 6.85 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 52.5 kB 52.5 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary Janpot/next.js jest-circus Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB
Overall change 26.3 kB 26.3 kB
Client Pages
zeit/next.js canary Janpot/next.js jest-circus Change
_app.js gzip 1.26 kB 1.26 kB
_error.js gzip 3.28 kB 3.28 kB
hooks.js gzip 881 B 881 B
index.js gzip 222 B 222 B
link.js gzip 2.06 kB 2.06 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 8.26 kB 8.26 kB
Client Pages Modern
zeit/next.js canary Janpot/next.js jest-circus Change
_app.module.js gzip 604 B 604 B
_error.module.js gzip 2.09 kB 2.09 kB
hooks.module.js gzip 383 B 383 B
index.module.js gzip 223 B 223 B
link.module.js gzip 1.52 kB 1.52 kB
routerDirect..dule.js gzip 281 B 281 B
withRouter.m..dule.js gzip 278 B 278 B
Overall change 5.38 kB 5.38 kB
Client Build Manifests
zeit/next.js canary Janpot/next.js jest-circus Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Serverless bundles
zeit/next.js canary Janpot/next.js jest-circus Change
_error.js 850 kB 850 kB
404.html 4.18 kB 4.18 kB
hooks.html 3.81 kB 3.81 kB
index.js 851 kB 851 kB
link.js 888 kB 888 kB
routerDirect.js 880 kB 880 kB
withRouter.js 880 kB 880 kB
Overall change 4.36 MB 4.36 MB

@ijjk
Copy link
Member

ijjk commented May 16, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
zeit/next.js canary Janpot/next.js jest-circus Change
buildDuration 13.1s 12.8s -356ms
nodeModulesSize 58.5 MB 58.5 MB
Page Load Tests Overall decrease ⚠️
zeit/next.js canary Janpot/next.js jest-circus Change
/ failed reqs 0 0
/ total time (seconds) 2.237 2.258 ⚠️ +0.02
/ avg req/sec 1117.62 1107.25 -10.37
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.414 1.468 ⚠️ +0.05
/error-in-render avg req/sec 1768.66 1702.71 -65.95
Client Bundles (main, webpack, commons)
zeit/next.js canary Janpot/next.js jest-circus Change
main-HASH.js gzip 6.68 kB 6.68 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..e49d.js gzip 10.4 kB 10.4 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57 kB 57 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary Janpot/next.js jest-circus Change
main-HASH.module.js gzip 5.72 kB 5.72 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.85 kB 6.85 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 52.5 kB 52.5 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary Janpot/next.js jest-circus Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB
Overall change 26.3 kB 26.3 kB
Client Pages
zeit/next.js canary Janpot/next.js jest-circus Change
_app.js gzip 1.26 kB 1.26 kB
_error.js gzip 3.28 kB 3.28 kB
hooks.js gzip 881 B 881 B
index.js gzip 222 B 222 B
link.js gzip 2.06 kB 2.06 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 8.26 kB 8.26 kB
Client Pages Modern
zeit/next.js canary Janpot/next.js jest-circus Change
_app.module.js gzip 604 B 604 B
_error.module.js gzip 2.09 kB 2.09 kB
hooks.module.js gzip 383 B 383 B
index.module.js gzip 223 B 223 B
link.module.js gzip 1.52 kB 1.52 kB
routerDirect..dule.js gzip 281 B 281 B
withRouter.m..dule.js gzip 278 B 278 B
Overall change 5.38 kB 5.38 kB
Client Build Manifests
zeit/next.js canary Janpot/next.js jest-circus Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Rendered Page Sizes
zeit/next.js canary Janpot/next.js jest-circus Change
index.html gzip 925 B 925 B
link.html gzip 936 B 936 B
withRouter.html gzip 922 B 922 B
Overall change 2.78 kB 2.78 kB

Serverless Mode
General
zeit/next.js canary Janpot/next.js jest-circus Change
buildDuration 13.8s 14s ⚠️ +191ms
nodeModulesSize 58.5 MB 58.5 MB
Client Bundles (main, webpack, commons)
zeit/next.js canary Janpot/next.js jest-circus Change
main-HASH.js gzip 6.68 kB 6.68 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..e49d.js gzip 10.4 kB 10.4 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57 kB 57 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary Janpot/next.js jest-circus Change
main-HASH.module.js gzip 5.72 kB 5.72 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.85 kB 6.85 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 52.5 kB 52.5 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary Janpot/next.js jest-circus Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB
Overall change 26.3 kB 26.3 kB
Client Pages
zeit/next.js canary Janpot/next.js jest-circus Change
_app.js gzip 1.26 kB 1.26 kB
_error.js gzip 3.28 kB 3.28 kB
hooks.js gzip 881 B 881 B
index.js gzip 222 B 222 B
link.js gzip 2.06 kB 2.06 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 8.26 kB 8.26 kB
Client Pages Modern
zeit/next.js canary Janpot/next.js jest-circus Change
_app.module.js gzip 604 B 604 B
_error.module.js gzip 2.09 kB 2.09 kB
hooks.module.js gzip 383 B 383 B
index.module.js gzip 223 B 223 B
link.module.js gzip 1.52 kB 1.52 kB
routerDirect..dule.js gzip 281 B 281 B
withRouter.m..dule.js gzip 278 B 278 B
Overall change 5.38 kB 5.38 kB
Client Build Manifests
zeit/next.js canary Janpot/next.js jest-circus Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Serverless bundles
zeit/next.js canary Janpot/next.js jest-circus Change
_error.js 850 kB 850 kB
404.html 4.18 kB 4.18 kB
hooks.html 3.81 kB 3.81 kB
index.js 851 kB 851 kB
link.js 888 kB 888 kB
routerDirect.js 880 kB 880 kB
withRouter.js 880 kB 880 kB
Overall change 4.36 MB 4.36 MB

@ijjk
Copy link
Member

ijjk commented May 16, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
zeit/next.js canary Janpot/next.js jest-circus Change
buildDuration 12.1s 12.3s ⚠️ +165ms
nodeModulesSize 58.5 MB 58.5 MB
Page Load Tests Overall decrease ⚠️
zeit/next.js canary Janpot/next.js jest-circus Change
/ failed reqs 0 0
/ total time (seconds) 2.001 1.946 -0.05
/ avg req/sec 1249.07 1284.57 ⚠️ +35.5
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.112 1.165 ⚠️ +0.05
/error-in-render avg req/sec 2248.14 2145.39 -102.75
Client Bundles (main, webpack, commons)
zeit/next.js canary Janpot/next.js jest-circus Change
main-HASH.js gzip 6.68 kB 6.68 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..e49d.js gzip 10.4 kB 10.4 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57 kB 57 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary Janpot/next.js jest-circus Change
main-HASH.module.js gzip 5.72 kB 5.72 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.85 kB 6.85 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 52.5 kB 52.5 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary Janpot/next.js jest-circus Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB
Overall change 26.3 kB 26.3 kB
Client Pages
zeit/next.js canary Janpot/next.js jest-circus Change
_app.js gzip 1.26 kB 1.26 kB
_error.js gzip 3.28 kB 3.28 kB
hooks.js gzip 881 B 881 B
index.js gzip 222 B 222 B
link.js gzip 2.06 kB 2.06 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 8.26 kB 8.26 kB
Client Pages Modern
zeit/next.js canary Janpot/next.js jest-circus Change
_app.module.js gzip 604 B 604 B
_error.module.js gzip 2.09 kB 2.09 kB
hooks.module.js gzip 383 B 383 B
index.module.js gzip 223 B 223 B
link.module.js gzip 1.52 kB 1.52 kB
routerDirect..dule.js gzip 281 B 281 B
withRouter.m..dule.js gzip 278 B 278 B
Overall change 5.38 kB 5.38 kB
Client Build Manifests
zeit/next.js canary Janpot/next.js jest-circus Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Rendered Page Sizes
zeit/next.js canary Janpot/next.js jest-circus Change
index.html gzip 925 B 925 B
link.html gzip 936 B 936 B
withRouter.html gzip 922 B 922 B
Overall change 2.78 kB 2.78 kB

Serverless Mode
General
zeit/next.js canary Janpot/next.js jest-circus Change
buildDuration 12.7s 12.8s ⚠️ +104ms
nodeModulesSize 58.5 MB 58.5 MB
Client Bundles (main, webpack, commons)
zeit/next.js canary Janpot/next.js jest-circus Change
main-HASH.js gzip 6.68 kB 6.68 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..e49d.js gzip 10.4 kB 10.4 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57 kB 57 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary Janpot/next.js jest-circus Change
main-HASH.module.js gzip 5.72 kB 5.72 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.85 kB 6.85 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 52.5 kB 52.5 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary Janpot/next.js jest-circus Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB
Overall change 26.3 kB 26.3 kB
Client Pages
zeit/next.js canary Janpot/next.js jest-circus Change
_app.js gzip 1.26 kB 1.26 kB
_error.js gzip 3.28 kB 3.28 kB
hooks.js gzip 881 B 881 B
index.js gzip 222 B 222 B
link.js gzip 2.06 kB 2.06 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 8.26 kB 8.26 kB
Client Pages Modern
zeit/next.js canary Janpot/next.js jest-circus Change
_app.module.js gzip 604 B 604 B
_error.module.js gzip 2.09 kB 2.09 kB
hooks.module.js gzip 383 B 383 B
index.module.js gzip 223 B 223 B
link.module.js gzip 1.52 kB 1.52 kB
routerDirect..dule.js gzip 281 B 281 B
withRouter.m..dule.js gzip 278 B 278 B
Overall change 5.38 kB 5.38 kB
Client Build Manifests
zeit/next.js canary Janpot/next.js jest-circus Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Serverless bundles
zeit/next.js canary Janpot/next.js jest-circus Change
_error.js 850 kB 850 kB
404.html 4.18 kB 4.18 kB
hooks.html 3.81 kB 3.81 kB
index.js 851 kB 851 kB
link.js 888 kB 888 kB
routerDirect.js 880 kB 880 kB
withRouter.js 880 kB 880 kB
Overall change 4.36 MB 4.36 MB

@Janpot Janpot marked this pull request as ready for review May 16, 2020 20:08
@ijjk
Copy link
Member

ijjk commented May 16, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
zeit/next.js canary Janpot/next.js jest-circus Change
buildDuration 11s 11.2s ⚠️ +248ms
nodeModulesSize 58.5 MB 58.5 MB
Page Load Tests Overall increase ✓
zeit/next.js canary Janpot/next.js jest-circus Change
/ failed reqs 0 0
/ total time (seconds) 1.744 1.74 0
/ avg req/sec 1433.57 1437.14 ⚠️ +3.57
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.161 1.095 -0.07
/error-in-render avg req/sec 2153.25 2282.27 ⚠️ +129.02
Client Bundles (main, webpack, commons)
zeit/next.js canary Janpot/next.js jest-circus Change
main-HASH.js gzip 6.68 kB 6.68 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..e49d.js gzip 10.4 kB 10.4 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57 kB 57 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary Janpot/next.js jest-circus Change
main-HASH.module.js gzip 5.72 kB 5.72 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.85 kB 6.85 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 52.5 kB 52.5 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary Janpot/next.js jest-circus Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB
Overall change 26.3 kB 26.3 kB
Client Pages
zeit/next.js canary Janpot/next.js jest-circus Change
_app.js gzip 1.26 kB 1.26 kB
_error.js gzip 3.28 kB 3.28 kB
hooks.js gzip 881 B 881 B
index.js gzip 222 B 222 B
link.js gzip 2.06 kB 2.06 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 8.26 kB 8.26 kB
Client Pages Modern
zeit/next.js canary Janpot/next.js jest-circus Change
_app.module.js gzip 604 B 604 B
_error.module.js gzip 2.09 kB 2.09 kB
hooks.module.js gzip 383 B 383 B
index.module.js gzip 223 B 223 B
link.module.js gzip 1.52 kB 1.52 kB
routerDirect..dule.js gzip 281 B 281 B
withRouter.m..dule.js gzip 278 B 278 B
Overall change 5.38 kB 5.38 kB
Client Build Manifests
zeit/next.js canary Janpot/next.js jest-circus Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Rendered Page Sizes
zeit/next.js canary Janpot/next.js jest-circus Change
index.html gzip 925 B 925 B
link.html gzip 936 B 936 B
withRouter.html gzip 922 B 922 B
Overall change 2.78 kB 2.78 kB

Serverless Mode
General
zeit/next.js canary Janpot/next.js jest-circus Change
buildDuration 11.2s 11.5s ⚠️ +312ms
nodeModulesSize 58.5 MB 58.5 MB
Client Bundles (main, webpack, commons)
zeit/next.js canary Janpot/next.js jest-circus Change
main-HASH.js gzip 6.68 kB 6.68 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..e49d.js gzip 10.4 kB 10.4 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57 kB 57 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary Janpot/next.js jest-circus Change
main-HASH.module.js gzip 5.72 kB 5.72 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.85 kB 6.85 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 52.5 kB 52.5 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary Janpot/next.js jest-circus Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB
Overall change 26.3 kB 26.3 kB
Client Pages
zeit/next.js canary Janpot/next.js jest-circus Change
_app.js gzip 1.26 kB 1.26 kB
_error.js gzip 3.28 kB 3.28 kB
hooks.js gzip 881 B 881 B
index.js gzip 222 B 222 B
link.js gzip 2.06 kB 2.06 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 8.26 kB 8.26 kB
Client Pages Modern
zeit/next.js canary Janpot/next.js jest-circus Change
_app.module.js gzip 604 B 604 B
_error.module.js gzip 2.09 kB 2.09 kB
hooks.module.js gzip 383 B 383 B
index.module.js gzip 223 B 223 B
link.module.js gzip 1.52 kB 1.52 kB
routerDirect..dule.js gzip 281 B 281 B
withRouter.m..dule.js gzip 278 B 278 B
Overall change 5.38 kB 5.38 kB
Client Build Manifests
zeit/next.js canary Janpot/next.js jest-circus Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Serverless bundles
zeit/next.js canary Janpot/next.js jest-circus Change
_error.js 850 kB 850 kB
404.html 4.18 kB 4.18 kB
hooks.html 3.81 kB 3.81 kB
index.js 851 kB 851 kB
link.js 888 kB 888 kB
routerDirect.js 880 kB 880 kB
withRouter.js 880 kB 880 kB
Overall change 4.36 MB 4.36 MB

@Timer Timer added this to the 9.4.1 milestone May 16, 2020
@Timer Timer merged commit 32057c8 into vercel:canary May 16, 2020
@Janpot Janpot deleted the jest-circus branch May 17, 2020 06:38
chibicode pushed a commit to chibicode/next.js that referenced this pull request May 21, 2020
rokinsky pushed a commit to rokinsky/next.js that referenced this pull request Jul 11, 2020
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants