Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: updated react to v17 on with-webassembly example #18916

Merged
merged 1 commit into from Nov 7, 2020
Merged

chore: updated react to v17 on with-webassembly example #18916

merged 1 commit into from Nov 7, 2020

Conversation

davidsonsns
Copy link
Contributor

@davidsonsns davidsonsns commented Nov 7, 2020 •
edited by Timer

Related #18518
Fixes #18867

@ijjk ijjk added the examples Issue/PR related to examples label Nov 7, 2020
@ijjk
Copy link
Member

ijjk commented Nov 7, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary davidsonsns/next.js canary Change
buildDuration 13.3s 13.2s -119ms
nodeModulesSize 84.9 MB 84.9 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary davidsonsns/next.js canary Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.454 2.458 0
/ avg req/sec 1018.66 1016.92 ⚠️ -1.74
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.34 1.31 -0.03
/error-in-render avg req/sec 1865.31 1908.18 +42.87
Client Bundles (main, webpack, commons)
vercel/next.js canary davidsonsns/next.js canary Change
677f882d2ed8..7d3b.js gzip 11.3 kB 11.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-d942eb5..343f.js gzip 7.4 kB 7.4 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58.4 kB 58.4 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary davidsonsns/next.js canary Change
677f882d2ed8..dule.js gzip 7.04 kB 7.04 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-34e64ff..dule.js gzip 6.39 kB 6.39 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 53.1 kB 53.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary davidsonsns/next.js canary Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary davidsonsns/next.js canary Change
_app-7231d4b..5856.js gzip 1.28 kB 1.28 kB ✓
_error-fca3d..2eb1.js gzip 3.44 kB 3.44 kB ✓
hooks-d4591d..e7c2.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-8a9d104..0e42.js gzip 1.55 kB 1.55 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.96 kB 7.96 kB ✓
Client Pages Modern
vercel/next.js canary davidsonsns/next.js canary Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-d1cfb87..dule.js gzip 1.49 kB 1.49 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.59 kB 5.59 kB ✓
Client Build Manifests
vercel/next.js canary davidsonsns/next.js canary Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 652 B 652 B ✓
Rendered Page Sizes
vercel/next.js canary davidsonsns/next.js canary Change
index.html gzip 1 kB 1 kB ✓
link.html gzip 1.01 kB 1.01 kB ✓
withRouter.html gzip 995 B 995 B ✓
Overall change 3.01 kB 3.01 kB ✓
Serverless Mode
General
vercel/next.js canary davidsonsns/next.js canary Change
buildDuration 15s 15.2s ⚠️ +214ms
nodeModulesSize 84.9 MB 84.9 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary davidsonsns/next.js canary Change
677f882d2ed8..7d3b.js gzip 11.3 kB 11.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-d942eb5..343f.js gzip 7.4 kB 7.4 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58.4 kB 58.4 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary davidsonsns/next.js canary Change
677f882d2ed8..dule.js gzip 7.04 kB 7.04 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-34e64ff..dule.js gzip 6.39 kB 6.39 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 53.1 kB 53.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary davidsonsns/next.js canary Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary davidsonsns/next.js canary Change
_app-7231d4b..5856.js gzip 1.28 kB 1.28 kB ✓
_error-fca3d..2eb1.js gzip 3.44 kB 3.44 kB ✓
hooks-d4591d..e7c2.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-8a9d104..0e42.js gzip 1.55 kB 1.55 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.96 kB 7.96 kB ✓
Client Pages Modern
vercel/next.js canary davidsonsns/next.js canary Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-d1cfb87..dule.js gzip 1.49 kB 1.49 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.59 kB 5.59 kB ✓
Client Build Manifests
vercel/next.js canary davidsonsns/next.js canary Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 652 B 652 B ✓
Serverless bundles
vercel/next.js canary davidsonsns/next.js canary Change
_error.js 914 kB 914 kB ✓
404.html 4.73 kB 4.73 kB ✓
hooks.html 3.92 kB 3.92 kB ✓
index.js 914 kB 914 kB ✓
link.js 963 kB 963 kB ✓
routerDirect.js 956 kB 956 kB ✓
withRouter.js 956 kB 956 kB ✓
Overall change 4.71 MB 4.71 MB ✓
Commit: 617edce

@Timer Timer merged commit 7820468 into vercel:canary Nov 7, 2020
@davidsonsns davidsonsns mentioned this pull request Nov 9, 2020
Merged
kodiakhq bot pushed a commit that referenced this pull request Nov 9, 2020
@davidsonsns
chore: fix some with-electron-typescript example setup (#18976)
019bbb2 
- Changed script `start` to `dev` and improved it #18934 adding commando to transpile electron code;
- Added some folders into `.gitignore`;
- Updated react to avoid issues as #18916

Fixes #18934
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Timer Timer Timer approved these changes

@chibicode chibicode Awaiting requested review from chibicode

@ijjk ijjk Awaiting requested review from ijjk

@lfades lfades Awaiting requested review from lfades

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
examples Issue/PR related to examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The example with-webassembly fails with invalid hook
3 participants
@davidsonsns @ijjk @Timer