Fix with-firebase-hosting running locally #21971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maerzhase
requested review from
chibicode,
ijjk,
lfades,
Timer and
timneutkens
as code owners
|
If anyone is finding this, update the deps is the best place to start |
leerob
reviewed
Feb 9, 2021
maerzhase
commented
Feb 9, 2021
leerob
approved these changes
Feb 9, 2021
This was referenced Feb 15, 2021
This was referenced Jan 18, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current version of the
with-firebase-hostingexample doesn't work locally. When you runnpm run servethe app starts and builds correctly but the requested pages are never served because the local cloudfunction is timing-out. Turns out updating thefirebase-related dependencies and usingnext-jsin its lastv9release fixes the problem.@jthegedus